Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[94x] l1t Muon Unpacker Zero Suppression and DQM. Clang cleaning. #20634

Merged

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Sep 23, 2017

PR 94x - Upgrade the Muon Unpacker and DQM to inteligentely handle Zero Suppression, making it BX aware. Also includes CLANG cleaning

Needed for data taking and available in the release at P5 before hardware change goes online (soon).

  • This is compatible with past, current, and future data.

(replaces #20477)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@rekovic
Copy link
Contributor Author

rekovic commented Sep 23, 2017

@davidlange6 your comment of moving the class into DataFormats is addressed in the last commit.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20634/930

@rekovic
Copy link
Contributor Author

rekovic commented Sep 23, 2017

please test

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rekovic for master.

It involves the following packages:

DQM/L1TMonitor
DataFormats/L1Trigger
EventFilter/L1TRawToDigi
L1Trigger/L1TMuon

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis, @kreczko, @rovere this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 23, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23183/console Started: 2017/09/23 11:46

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@rekovic
Copy link
Contributor Author

rekovic commented Sep 23, 2017

+1

@rekovic
Copy link
Contributor Author

rekovic commented Sep 23, 2017

@dmitrijus
This is the same PR as the one you signed #20477. Please sign this one as well.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20634/23183/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2691683
  • DQMHistoTests: Total failures: 211
  • DQMHistoTests: Total nulls: 89
  • DQMHistoTests: Total successes: 2691194
  • DQMHistoTests: Total skipped: 189
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 15 edm output root files, 26 DQM output files

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit e4fd1ba into cms-sw:master Sep 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants