Better splitting and Tcrit definition for 4D vertexing #20709

lgray · 2017-10-01T22:46:26Z

This PR implements an improved splitting strategy and better Tcrit definition for track clusters in time-aware vertexing. Improvements are from @werdmann.

This significantly speeds up vertexing to the point that the minimum pT cut that has been in place before may be removed.

lgray · 2017-10-01T22:46:38Z

@cmsbuild please test

cmsbuild · 2017-10-01T22:46:45Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-10-01T22:51:04Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20709/1078

cmsbuild · 2017-10-01T22:51:25Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23347/console Started: 2017/10/02 03:11

cmsbuild · 2017-10-01T22:51:26Z

A new Pull Request was created by @lgray (Lindsey Gray) for master.

It involves the following packages:

RecoVertex/Configuration
RecoVertex/PrimaryVertexProducer

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2017-10-02T02:41:06Z

-1

Tested at: de1d395

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e1481ad
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/23347/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/23347/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/23347/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1003.0 step2

runTheMatrix-results/1003.0_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM/step2_RunMinBias2012A+RunMinBias2012A+RECODDQM+HARVESTDDQM.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:07:13 2017-date Mon Oct 2 04:06:01 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:07:35 2017-date Mon Oct 2 04:06:06 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v31,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v31 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v31_MC.root --fileout file:RelVal_Raw_2e34v31_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:18:51 2017-date Mon Oct 2 04:06:08 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v30,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v30 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v30_MC.root --fileout file:RelVal_Raw_2e34v30_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:18:55 2017-date Mon Oct 2 04:06:09 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:14:29 2017-date Mon Oct 2 04:06:16 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:20:03 2017-date Mon Oct 2 04:06:27 2017 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Mon Oct 2 04:08:22 2017-date Mon Oct 2 04:06:49 2017 s - exit: 16640
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Mon Oct 2 04:10:08 2017-date Mon Oct 2 04:07:20 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:13:15 2017-date Mon Oct 2 04:07:42 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v31,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v31 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v31_DATA.root --fileout file:RelVal_Raw_2e34v31_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:18:53 2017-date Mon Oct 2 04:10:18 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v30,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v30 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v30_DATA.root --fileout file:RelVal_Raw_2e34v30_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:20:55 2017-date Mon Oct 2 04:13:20 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:24:06 2017-date Mon Oct 2 04:14:33 2017 s - exit: 16640
cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Mon Oct 2 04:18:04 2017-date Mon Oct 2 04:16:17 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_MC.root --fileout file:RelVal_Raw_2e34v22_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:32:58 2017-date Mon Oct 2 04:18:11 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:30:02 2017-date Mon Oct 2 04:18:53 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:38:38 2017-date Mon Oct 2 04:18:58 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:32:22 2017-date Mon Oct 2 04:19:02 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:31:39 2017-date Mon Oct 2 04:20:03 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:24:07 2017-date Mon Oct 2 04:20:07 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:32:10 2017-date Mon Oct 2 04:21:02 2017 s - exit: 16640
cmsDriver.py RelVal -s HLT:2e34v22,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_2e34v22 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2017 --processName=HLTRECO --filein file:RelVal_Raw_2e34v22_DATA.root --fileout file:RelVal_Raw_2e34v22_DATA_HLT_RECO.root : FAILED - time: date Mon Oct 2 04:32:44 2017-date Mon Oct 2 04:24:06 2017 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e1481ad
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/23347/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/23347/git-merge-result

cmsbuild · 2017-10-02T02:41:08Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

lgray · 2017-10-02T02:43:33Z

Errors due to missing ctpps external.

perrotta · 2017-10-02T07:11:13Z

please test

cmsbuild · 2017-10-02T07:11:31Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23349/console Started: 2017/10/02 10:02

cmsbuild · 2017-11-06T17:23:52Z

+1
Tested at: 0b15a42
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/24202/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
fcaeeab
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/24202/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/24202/git-merge-result

cmsbuild · 2017-11-06T17:23:55Z

Comparison job queued.

cmsbuild · 2017-11-06T19:08:45Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20709/24202/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 18 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2900266
DQMHistoTests: Total failures: 113
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2899982
DQMHistoTests: Total skipped: 171
DQMHistoTests: Total Missing objects: 0
Checked 107 log files, 10 edm output root files, 26 DQM output files

slava77 · 2017-11-07T12:16:26Z

it looks like the bugfix in splitting has pretty small effect inclusively

red is with 0b15a42 and black is with 48191e4

dup, eff, fr, merged plots look fairly consistent as well.

lgray · 2017-11-07T13:52:16Z

So long as the same number of splits are happening (more or less) you'll arrive to the ~same solution. When this bug was triggered, which apparently is not too often to begin with, it was likely causing updates to take a while (since you put a new vertex in some crazy location).

Did you see any changes in tails for computing time?

Otherwise it's fine by me.

slava77 · 2017-11-07T14:24:01Z

On 11/7/17 2:52 PM, Lindsey Gray wrote: So long as the same number of splits are happening (more or less) you'll arrive to the ~same solution. When this bug was triggered, which apparently is not too often to begin with, it was likely causing updates to take a while (since you put a new vertex in some crazy location). Did you see any changes in tails for computing time?

average [mode] is up by a few %. There is one event taking a long time that went away. However, the tests are using the full reco step which still has track time randomized. So, the observation about the tails is not conclusive.

…

Otherwise it's fine by me. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#20709 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEdcbiNoHq0sM5OaAot4nY26wqzBVCtZks5s0GCRgaJpZM4PqD9J>.

perrotta · 2017-11-09T11:48:34Z

Hi @lgray : were you finally able to prepare the comparisons that you anticipated in #20709 (comment)?

It would be nice to verify explicitely the whole effect of this PR on high PU samples before signing it

lgray · 2017-11-09T17:25:36Z

@perrotta Given the tiny changes from the fix to the vertex re-packing in the case of very dense regions of the beamspot (clearly this doesn't happen a lot), the changes are summarized entirely by @slava77's prior plots on fake rate / duplicates / spectra.

kpedro88 · 2017-11-09T17:38:08Z

+1

perrotta · 2017-11-09T17:40:53Z

+1

Improved splitting strategy and better Tcrit definition for track clusters in 4D vertexing
Performances are summarized in Better splitting and Tcrit definition for 4D vertexing #20709 (comment), and latest fixes only slightly modify that figure (see Better splitting and Tcrit definition for 4D vertexing #20709 (comment) )
Timing improvements allow relaxing the previous pt cut
Timing in 4D vertexing measured in Better splitting and Tcrit definition for 4D vertexing #20709 (comment):
- offlinePrimaryVertices4DWithBS times go up by about 50% from about 230 ms to 400 ms. This is from an increase in the number of vertices.
- unsortedOfflinePrimaryVertices4D from 33 s/e to 36 s/e

cmsbuild · 2017-11-09T17:41:25Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

davidlange6 · 2017-11-10T08:57:18Z

merge

cmsbuild added this to the CMSSW_9_4_X milestone Oct 1, 2017

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Oct 1, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Oct 1, 2017

cmsbuild added tests-started and removed tests-pending labels Oct 1, 2017

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Oct 2, 2017

cmsbuild added comparison-pending tests-pending and removed comparison-notrun tests-rejected labels Oct 2, 2017

cmsbuild removed the tests-pending label Oct 2, 2017

cmsbuild added the tests-started label Nov 6, 2017

cmsbuild added tests-approved and removed tests-started labels Nov 6, 2017

This was referenced Nov 6, 2017

Better splitting and Tcrit definition for 4D vertexing (94X) #21189

Closed

Better splitting and Tcrit definition for 4D vertexing (93X) #21190

Merged

cmsbuild added comparison-available and removed comparison-pending labels Nov 6, 2017

cmsbuild added upgrade-approved and removed upgrade-pending labels Nov 9, 2017

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Nov 9, 2017

cmsbuild added orp-approved and removed orp-pending labels Nov 10, 2017

cmsbuild merged commit c92d92a into cms-sw:master Nov 10, 2017

This was referenced Nov 10, 2017

unsortedOfflinePrimaryVertices4D speedup for 2023 timing workflows #17826

Closed

Excessive time spent in PrimaryVertexProducer in 200PU #17604

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better splitting and Tcrit definition for 4D vertexing #20709

Better splitting and Tcrit definition for 4D vertexing #20709

lgray commented Oct 1, 2017

lgray commented Oct 1, 2017

cmsbuild commented Oct 1, 2017

cmsbuild commented Oct 1, 2017

cmsbuild commented Oct 1, 2017 •

edited

cmsbuild commented Oct 1, 2017

cmsbuild commented Oct 2, 2017

cmsbuild commented Oct 2, 2017

lgray commented Oct 2, 2017

perrotta commented Oct 2, 2017

cmsbuild commented Oct 2, 2017 •

edited

cmsbuild commented Nov 6, 2017

cmsbuild commented Nov 6, 2017

cmsbuild commented Nov 6, 2017

slava77 commented Nov 7, 2017

lgray commented Nov 7, 2017

slava77 commented Nov 7, 2017 via email

perrotta commented Nov 9, 2017

lgray commented Nov 9, 2017

kpedro88 commented Nov 9, 2017

perrotta commented Nov 9, 2017

cmsbuild commented Nov 9, 2017

davidlange6 commented Nov 10, 2017

Better splitting and Tcrit definition for 4D vertexing #20709

Better splitting and Tcrit definition for 4D vertexing #20709

Conversation

lgray commented Oct 1, 2017

lgray commented Oct 1, 2017

cmsbuild commented Oct 1, 2017

cmsbuild commented Oct 1, 2017

cmsbuild commented Oct 1, 2017 • edited

cmsbuild commented Oct 1, 2017

cmsbuild commented Oct 2, 2017

cmsbuild commented Oct 2, 2017

lgray commented Oct 2, 2017

perrotta commented Oct 2, 2017

cmsbuild commented Oct 2, 2017 • edited

cmsbuild commented Nov 6, 2017

cmsbuild commented Nov 6, 2017

cmsbuild commented Nov 6, 2017

slava77 commented Nov 7, 2017

lgray commented Nov 7, 2017

slava77 commented Nov 7, 2017 via email

perrotta commented Nov 9, 2017

lgray commented Nov 9, 2017

kpedro88 commented Nov 9, 2017

perrotta commented Nov 9, 2017

cmsbuild commented Nov 9, 2017

davidlange6 commented Nov 10, 2017

cmsbuild commented Oct 1, 2017 •

edited

cmsbuild commented Oct 2, 2017 •

edited