[94X] L1 no hack conditions - cleaned #20871
Conversation
This reverts commit dd6b5f8.
…to use 2016 data, (2) L1REPACK Full2015Data not to use static config file and ESProducer for HF TPs.
…structing helper from CaloParams!
…s GT not yet updated. Turn-off hackConditions in Offline DQM.
…- keep the PR clean.
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
Differences in Muons BMTF are due to differences in params available in external LUTs vs Prototype payload used when configuring via GT. The payload is updated and requested from AlCa to include GT. Differences in Calo are due to static configuration which used the latest greatest configuration for all data IOVs, while this PR choses the configuration according to the run numbers and IOV, which is the correct thing to do.
|
|
merge |
|
Test to see the effects of the further changes in GTs |
|
please test with #20758 |
|
The tests are being triggered in jenkins. |
cmsbuild
added
comparison-pending
tests-pending
tests-started
and removed
tests-approved
tests-pending
labels
|
probably need to open another PR for testing only. |
|
maybe not, tests just started. |
|
|
||
| #include "TMath.h" | ||
| // | ||
| // class declaration | ||
| // | ||
| using namespace l1t; | ||
|
|
||
| class L1TMuonProducer : public edm::stream::EDProducer<> { | ||
| class L1TMuonProducer : public edm::EDProducer { |
There was a problem hiding this comment.
@rekovic why was this moved back to being an EDProducer? Was this a mistake when trying to resolve the conflict?
|
Indeed - Can't have that for threading. Must be moved back to stream or so. |
|
-1 Tested at: f96f59c The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: RelVals
When I ran the RelVals I found an error in the following worklfows: runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step3_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log10024.0 step5 runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step5_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
Configure emulators from DB.
This is a cleaned-up version of #20577.
Details: