Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM for AK8 btag HLT #20898

Merged
merged 10 commits into from Oct 18, 2017
Merged

DQM for AK8 btag HLT #20898

merged 10 commits into from Oct 18, 2017

Conversation

Michael-Krohn
Copy link
Contributor

Added DQM modules for the 2 HLT paths for the gluon fusion H to bb search.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20898/1407

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Michael-Krohn for master.

It involves the following packages:

DQMOffline/Trigger

@kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @trocino, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@heppye
Copy link
Contributor

heppye commented Oct 12, 2017

PR needed for version4 HLT menu. Proposal approved by TSG. Green light from HIG for DQM implementation. @steam @mtosi, @dqm @dmitrijus , could you please provide quick check? Thanks, Ye for HIG.

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017

@Michael-Krohn could you please quantify the increase in #bins ?
thanks

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23704/console Started: 2017/10/12 09:51

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20898/23704/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767051
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766772
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@Michael-Krohn
Copy link
Contributor Author

@mtosi The increase in #bins from what?

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017 via email

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@Michael-Krohn
Copy link
Contributor Author

@mtosi I now count 1530 bins per path, so 3060 total bins

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-20898/1436

@cmsbuild
Copy link
Contributor

Pull request #20898 was updated. @kmaeshima, @cmsbuild, @vanbesien, @vazzolini, @dmitrijus can you please check and sign again.

@mtosi
Copy link
Contributor

mtosi commented Oct 12, 2017

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 12, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/23738/console Started: 2017/10/12 20:44

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-20898/23738/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2767051
  • DQMHistoTests: Total failures: 118
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2766762
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit fa3bd53 into cms-sw:master Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants