New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removing ThePEGInterface interface in favor of the H7 interface #21052
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for master. It involves the following packages: GeneratorInterface/ThePEGInterface @cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with #21050 cms-sw/cmsdist#3519 |
1 similar comment
please test with #21050 cms-sw/cmsdist#3519 |
The tests are being triggered in jenkins. |
-1 Tested at: fca6f1b The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: Entering library rule at src/SimG4CMS/HGCalTestBeam/plugins Entering library rule at SimG4CMS/HGCalTestBeam Entering library rule at src/PhysicsTools/PatAlgos/plugins Entering library rule at PhysicsTools/PatAlgos >> Compiling /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-10-27-1100/src/PhysicsTools/PatAlgos/test/runtestPhysicsToolsPatAlgos.cpp /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-10-27-1100/src/GeneratorInterface/Herwig7Interface/src/RandomEngineGlue.cc:5:49: fatal error: ThePEG/Interface/ClassDocumentation.h: No such file or directory #include ^ compilation terminated. /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-10-27-1100/src/GeneratorInterface/Herwig7Interface/plugins/Herwig7Hadronizer.cc:7:42: fatal error: ThePEG/Repository/Repository.h: No such file or directory #include The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
@Andrej-CMS seems like something is missing in |
@perrozzi : You have to do |
please test with #21050 cms-sw/cmsdist#3519 |
@alberto-sanchez @perrozzi Looking at the test results page: Thus, I see no reason why this PR cannot be merged Therefore, I would kindly ask you to merge this PR finally since the failing check is totally unrelated to the changes of the PR and we would really need Herwig7 for an event generation. |
please test with #21050 cms-sw/cmsdist#3519 |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
merge |
please test with #21050 cms-sw/cmsdist#3519