Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing ThePEGInterface interface in favor of the H7 interface #21052

Merged
merged 1 commit into from Jan 16, 2018

Conversation

alberto-sanchez
Copy link
Member

@alberto-sanchez alberto-sanchez commented Oct 27, 2017

please test with #21050 cms-sw/cmsdist#3519

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21052/1685

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @alberto-sanchez (Alberto Sanchez Hernandez) for master.

It involves the following packages:

GeneratorInterface/ThePEGInterface

@cmsbuild, @efeyazgan, @perrozzi, @thuer, @govoni can you please review it and eventually sign? Thanks.
@agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member Author

please test with #21050 cms-sw/cmsdist#3519

1 similar comment
@perrozzi
Copy link
Contributor

please test with #21050 cms-sw/cmsdist#3519

@cmsbuild
Copy link
Contributor

cmsbuild commented Oct 27, 2017

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3519
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24024/console

@cmsbuild
Copy link
Contributor

-1

Tested at: fca6f1b

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
917c3f6
45a2438
566160a
33f1e74
40c0ef7
57b9354
dafc5c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24024/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24024/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24024/summary.html

I found follow errors while testing this PR

Failed tests: Build

  • Build:

I found an error when building:

Entering library rule at src/SimG4CMS/HGCalTestBeam/plugins
Entering library rule at SimG4CMS/HGCalTestBeam
Entering library rule at src/PhysicsTools/PatAlgos/plugins
Entering library rule at PhysicsTools/PatAlgos
>> Compiling  /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-10-27-1100/src/PhysicsTools/PatAlgos/test/runtestPhysicsToolsPatAlgos.cpp 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-10-27-1100/src/GeneratorInterface/Herwig7Interface/src/RandomEngineGlue.cc:5:49: fatal error: ThePEG/Interface/ClassDocumentation.h: No such file or directory
 #include 
                                                 ^
compilation terminated.
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_4_X_2017-10-27-1100/src/GeneratorInterface/Herwig7Interface/plugins/Herwig7Hadronizer.cc:7:42: fatal error: ThePEG/Repository/Repository.h: No such file or directory
 #include 


The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
917c3f6
45a2438
566160a
33f1e74
40c0ef7
57b9354
dafc5c3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24024/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24024/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

@alberto-sanchez
Copy link
Member Author

@Andrej-CMS seems like something is missing in
GeneratorInterface/Herwig7Interface/BuildFile.xml

@alberto-sanchez
Copy link
Member Author

@perrozzi : You have to do
please test with #21050 cms-sw/cmsdist#3519

@efeyazgan
Copy link
Contributor

please test with #21050 cms-sw/cmsdist#3519

@mharrend
Copy link
Contributor

@alberto-sanchez @perrozzi Looking at the test results page:
The compilation and externals compilation tests succeed, cf. https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24587/cmsswtoolconf.log and https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24587/build.log

Thus, I see no reason why this PR cannot be merged

Therefore, I would kindly ask you to merge this PR finally since the failing check is totally unrelated to the changes of the PR and we would really need Herwig7 for an event generation.

@perrozzi
Copy link
Contributor

please test with #21050 cms-sw/cmsdist#3519

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 27, 2017

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#3519
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24693/console

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21052/24693/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2777437
  • DQMHistoTests: Total failures: 107
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2777159
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@perrozzi
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit ad0debb into cms-sw:master Jan 16, 2018
@alberto-sanchez alberto-sanchez deleted the RemoveThePEGInterface branch May 11, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants