Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HGCal aging [93X] #21157

Merged
merged 2 commits into from Nov 21, 2017
Merged

Fix HGCal aging [93X] #21157

merged 2 commits into from Nov 21, 2017

Conversation

kpedro88
Copy link
Contributor

@kpedro88 kpedro88 commented Nov 3, 2017

Backport of #21156

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_9_3_X.

It involves the following packages:

SLHCUpgradeSimulations/Configuration
SimCalorimetry/HGCalSimProducers

@cmsbuild, @civanch, @mdhildreth, @kpedro88 can you please review it and eventually sign? Thanks.
@cseez, @vandreev11, @sethzenz, @makortel, @sviret, @lgray, @Martin-Grunewald, @pfs, @ebrondol this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

kpedro88 commented Nov 3, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24165/console Started: 2017/11/03 19:54

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21157/24165/summary.html

There are some workflows for which there are errors in the baseline:
1306.0 step 4
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2550877
  • DQMHistoTests: Total failures: 220
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2550480
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • Checked 103 log files, 9 edm output root files, 25 DQM output files

@civanch
Copy link
Contributor

civanch commented Nov 4, 2017

+1

@kpedro88
Copy link
Contributor Author

kpedro88 commented Nov 4, 2017

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 4, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@rovere rovere mentioned this pull request Nov 4, 2017
@kpedro88
Copy link
Contributor Author

@davidlange6 please merge

@davidlange6
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 6ae5347 into cms-sw:CMSSW_9_3_X Nov 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants