Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HGCal aging [93X] #21157

Merged
merged 2 commits into from Nov 21, 2017
Merged

Fix HGCal aging [93X] #21157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a161ef4
don't try to modify a nonexistent digitizer
kpedro88 Nov 3, 2017
edee7df
fix type
kpedro88 Nov 3, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions SLHCUpgradeSimulations/Configuration/python/aging.py
View file
Open in desktop
Expand Up @@ -61,9 +61,9 @@ def ageHF(process,turnon):

def agedHGCal(process):
from SimCalorimetry.HGCalSimProducers.hgcalDigitizer_cfi import HGCal_setEndOfLifeNoise
HGCal_setEndOfLifeNoise(getHGCalDigitizer(process,'EE'))
HGCal_setEndOfLifeNoise(getHGCalDigitizer(process,'FH'))
HGCal_setEndOfLifeNoise(getHGCalDigitizer(process,'BH'))
for subdet in ['EE','FH','BH']:
hgcaldigi = getHGCalDigitizer(process,subdet)
if hgcaldigi is not None: HGCal_setEndOfLifeNoise(hgcaldigi)
return process

# needs lumi to set proper ZS thresholds (tbd)
Expand Down
4 changes: 2 additions & 2 deletions SimCalorimetry/HGCalSimProducers/python/hgcalDigitizer_cfi.py
View file
Open in desktop
Expand Up @@ -157,6 +157,6 @@
def HGCal_setEndOfLifeNoise(digitizer):
if( digitizer.digiCollection != "HGCDigisHEback" ):
digitizer.digiCfg.noise_fC = cms.vdouble( [x*fC_per_ele for x in endOfLifeNoises] )
digitizer.digiCfg.chargeCollectionEfficiency = cms.double(endOfLifeCCEs)
digitizer.digiCfg.chargeCollectionEfficiency = cms.vdouble(endOfLifeCCEs)
else: #use S/N of 7 for SiPM readout
digitizer.digiCfg.noise_MIP = cms.vdouble( 1.0/5.0 )
digitizer.digiCfg.noise_MIP = cms.double( 1.0/5.0 )