Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in DQMGenericClient #21184

Merged
merged 1 commit into from Nov 7, 2017

Conversation

dmitrijus
Copy link
Contributor

@dmitrijus
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24201/console Started: 2017/11/06 15:41

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_9_4_X.

It involves the following packages:

DQMServices/ClientConfig

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @barvic this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2017

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21184/24201/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2838442
  • DQMHistoTests: Total failures: 130
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2838141
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • Checked 107 log files, 10 edm output root files, 26 DQM output files

@dmitrijus
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2017

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@davidlange6
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit dd2739d into cms-sw:CMSSW_9_4_X Nov 7, 2017
@mtosi
Copy link
Contributor

mtosi commented Nov 8, 2017

I've just seen this PR,
do we have the analogous one for 92x ?
as far as I understood, we have a similar issue in recent relval production done in 9_2_14
@fabozzi do you confirm ?

@fabozzi
Copy link
Contributor

fabozzi commented Nov 8, 2017

yes, and it is already been merged as well

@fabozzi
Copy link
Contributor

fabozzi commented Nov 8, 2017

#21199

@mtosi
Copy link
Contributor

mtosi commented Nov 8, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants