Fix memory leak in DQMGenericClient. #21199
Conversation
Fixes https://its.cern.ch/jira/browse/CMSCOMPPR-1606 (cherry picked from commit 0292bfa)
|
+1 |
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_2_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
|
A new Pull Request was created by @dmitrijus (Dmitrijus) for CMSSW_9_2_X. It involves the following packages: DQMServices/ClientConfig @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
| @@ -512,6 +512,7 @@ void DQMGenericClient::computeEfficiency (DQMStore::IBooker& ibooker, DQMStore:: | |||
| efficME = ibooker.book3D(newEfficMEName, (TH3F*)efficHist); | |||
| } | |||
|
|
|||
| delete efficHist; | |||
There was a problem hiding this comment.
Using std::unique_ptr would be a better solution for the future.
There was a problem hiding this comment.
I know, just delete was already used in this file.
|
merge |
Fixes https://its.cern.ch/jira/browse/CMSCOMPPR-1606
(cherry picked from commit 0292bfa)