Fix fastsim generalTracks for premixing case

[Dr15Jones]

The change to fastsim making futher use of eras did not properly
handle the case where premixing is being used.

[cmsbuild]

The code-checks are being triggered in jenkins.

[Dr15Jones]

The way classic mixing and premixing are setup for fastsim seem kind of brittle. It would be good if someone who knew more about it could take a look to see if a more robust mechanism could be used.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21263/1931

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

FastSimulation/Configuration
RecoTracker/FinalTrackSelectors

@perrotta, @civanch, @lveldere, @ssekmen, @mdhildreth, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@ghellwig, @makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @Martin-Grunewald, @mschrode, @gpetruc, @matt-komm, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test workflow 250400.0, 250402.0, 250403.0, 250405.0, 250406.0, 250407.0, 250408.0, 250409.0

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24354/console Started: 2017/11/10 18:09

[cmsbuild]

+1
Tested at: dfdf2e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24354/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
62cb420
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24354/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24354/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24354/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2832699
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2832520
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.950000000099 KiB( 22 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[slava77]

+1

for #21263 dfdf2e2

• fix fastsim with premix
• jenkins tests pass and there are no differences in regular workflows and the additional FS premix workflows tested run to completion

[Dr15Jones]

250399.0 was expected to fail because it is failing in the IB and this pull request does not address that problem.

[ssekmen]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1 On 13 Nov 2017, at 15:25, cmsbuild <notifications@github.com<mailto:notifications@github.com>> wrote: This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @davidlange6<https://github.com/davidlange6>, @slava77<https://github.com/slava77>, @smuzaffar<https://github.com/smuzaffar> (and backports should be raised in the release meeting by the corresponding L2) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#21263 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEzywzBcNsqbUXsIJJPjazyWjCyENtm0ks5s2FEpgaJpZM4QZtk1>.

[perrotta]

@davidlange6 : I think you must say "merge" explicitely, because last tests were broken, #21263 (comment)

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24411/console Started: 2017/11/14 08:47

[davidlange6]

merge

[cmsbuild]

+1
Tested at: dfdf2e2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24411/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
5686e5c
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24411/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24411/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21263/24411/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2832924
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2832745
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.960000000028 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files