Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move fast sim reco to eras - backport to 94X #24391

Merged
merged 5 commits into from Aug 28, 2018
Merged

Move fast sim reco to eras - backport to 94X #24391

merged 5 commits into from Aug 28, 2018

Conversation

ssekmen
Copy link
Contributor

@ssekmen ssekmen commented Aug 25, 2018 •
edited

Backport of PR #20884 to 94X
Also incorporated the changes from #21263 and #21276 .

@cmsbuild cmsbuild added this to the CMSSW_9_4_X milestone Aug 25, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2018 •
edited

A new Pull Request was created by @ssekmen (Sezen Sekmen) for CMSSW_9_4_X.

It involves the following packages:

Configuration/StandardSequences
FastSimulation/Configuration
FastSimulation/Tracking
RecoEcal/EgammaClusterProducers
RecoEgamma/Configuration
RecoEgamma/EgammaPhotonProducers
RecoLocalCalo/Configuration
RecoLocalCalo/EcalRecProducers
RecoMET/Configuration
RecoMuon/Configuration
RecoMuon/GlobalMuonProducer
RecoMuon/GlobalTrackingTools
RecoMuon/MuonIdentification
RecoMuon/TrackingTools
RecoParticleFlow/PFTracking
RecoTracker/Configuration
RecoTracker/FinalTrackSelectors
RecoTracker/IterativeTracking
RecoTracker/MeasurementDet
TrackingTools/GsfTracking
TrackingTools/TrackRefitter

@perrotta, @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @felicepantaleo, @jainshilpi, @abbiendi, @argiro, @Martin-Grunewald, @ahinzmann, @lgray, @varuns23, @seemasharmafnal, @mmarionncern, @battibass, @makortel, @jhgoh, @dgulhan, @jdolen, @HuguesBrun, @drkovalskyi, @trocino, @rociovilar, @Sam-Harper, @GiacomoSguazzoni, @rovere, @VinInn, @jdamgov, @bellan, @nhanvtran, @gkasieczka, @schoef, @mschrode, @ebrondol, @amagitte, @clelange, @echapon, @calderona, @folguera, @cbernet, @gpetruc, @matt-komm, @mariadalfonso, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ssekmen ssekmen changed the title Move fast sim reco to eras for 94X Move fast sim reco to eras - backport to 94X Aug 25, 2018
@ssekmen
Copy link
Contributor Author

ssekmen commented Aug 25, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 25, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30061/console Started: 2018/08/26 00:11

@cmsbuild
Copy link
Contributor

+1
Tested at: 9dc15e1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24391/30061/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24391/30061/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 104
  • DQMHistoTests: Total nulls: 238
  • DQMHistoTests: Total successes: 2720989
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@ssekmen
Copy link
Contributor Author

ssekmen commented Aug 26, 2018

+1

@perrotta
Copy link
Contributor

perrotta commented Aug 26, 2018 •
edited

@ssekmen @Dr15Jones
The parent pull request merged in the master needed #21263 as a later fix. I think it should also merged here, isn't it?

@perrotta
Copy link
Contributor

... as well as #21276

@ssekmen
Copy link
Contributor Author

ssekmen commented Aug 26, 2018

@Perrota , thanks, yes, I noticed that and am working to incorporate these.

@cmsbuild
Copy link
Contributor

Pull request #24391 was updated. @perrotta, @andrius-k, @lveldere, @kmaeshima, @civanch, @schneiml, @ssekmen, @mdhildreth, @cmsbuild, @franzoni, @jfernan2, @slava77, @fabiocos, @davidlange6 can you please check and sign again.

@ssekmen
Copy link
Contributor Author

ssekmen commented Aug 27, 2018

please test workflow 250400.0, 250402.0, 250403.0, 250405.0, 250406.0, 250407.0, 250408.0, 250409.0

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 27, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/30075/console Started: 2018/08/27 18:36

@cmsbuild
Copy link
Contributor

+1
Tested at: 04edae9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24391/30075/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-24391/30075/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250400.0_ZEE_13+FS_ZEE_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250402.0_TTbar_13+FS_TTbar_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250403.0_H125GGgluonfusion_13+FS_H125GGgluonfusion_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250405.0_ZTT_13+FS_ZTT_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250406.0_ZMM_13+FS_ZMM_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250407.0_NuGun_UP15+FS_NuGun_UP15_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250408.0_QCD_FlatPt_15_3000HS_13+FS_QCD_FlatPt_15_3000HS_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-24391/250409.0_SMS-T1tttt_mGl-1500_mLSP-100_13+FS_SMS-T1tttt_mGl-1500_mLSP-100_13_PRMXUP15_PU25+HARVESTUP15FS+MINIAODMCUP15FS

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 122
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721209
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@perrotta
Copy link
Contributor

+1

@ssekmen
Copy link
Contributor Author

ssekmen commented Aug 27, 2018

+1

@andrius-k
Copy link

+1

@kpedro88
Copy link
Contributor

backport of #20884

@kpedro88
Copy link
Contributor

+1

@kpedro88
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 0f4169c into cms-sw:CMSSW_9_4_X Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@perrotta perrotta perrotta left review comments

Assignees
No one assigned
Labels
backport-ok comparison-available dqm-approved fastsim-approved operations-pending orp-approved pending-signatures reconstruction-approved tests-approved
Projects
None yet
Milestone
CMSSW_9_4_X
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ssekmen @cmsbuild @perrotta @Dr15Jones @andrius-k @kpedro88 @makortel