L1T online and offline DQM configuration upgrades

[thomreis]

L1T online and offline DQM improvements.

• Move the TF emulators and the uGT emulator before the fat event filter to have better statistics for the comparisons. This means the modules are then also ran in the offline DQM.
• Ignore BX range mismatches for BMTF and EMTF data to emulator comparison in the summary.
• Remove the old unpacker for CaloLayer1 and use the rawToDigi standard sequence instead.
• Remove unneeded unpackers from the online DQM clients.
• Add the ESProducer for the ideal magnetic field to the online client because it is needed by the EMTF emulator.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21334/2028

[cmsbuild]

A new Pull Request was created by @thomreis (Thomas Reis) for master.

It involves the following packages:

DQM/Integration
DQM/L1TMonitor
DQM/L1TMonitorClient
DQMOffline/L1Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @rekovic, @jfernan2, @vanbesien, @mulhearn can you please review it and eventually sign? Thanks.
@makortel, @rociovilar, @threus, @kreczko, @batinkov this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24483/console Started: 2017/11/16 20:22

[cmsbuild]

+1
Tested at: df73493
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21334/24483/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
c8c0943
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21334/24483/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21334/24483/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21334/24483/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2833444
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2833265
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 528.67 KiB( 23 files compared)
• Checked 111 log files, 8 edm output root files, 27 DQM output files

[rekovic]

+1

[thomreis]

Hi @jfernan2 , @dmitrijus
could you take a look at this PR and its backport please and let me know if things are OK?

[dmitrijus]

This adds a half a megabyte worth of histograms, is this intentional?

[thomreis]

Yes, this should add additional histograms to the L1TEMU directory in the offline DQM. Previously the modules have not been running since they were in a sequence that was only after the fat event filter in the online DQM.

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

hi @dmitrijus - to clarify its 0.5MB spread across 23 files.. (probably this monitoring needs to also track the biggest single increase)

[davidlange6]

its probably more maintainable to include the unpackers you want instead...

[davidlange6]

+1