Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr940 RPCTwinMux in L1TRawToDigi Sequence #21352

Closed

Conversation

rekovic
Copy link
Contributor

@rekovic rekovic commented Nov 17, 2017

Fix: put dropped RPCTwinMux unpacker back into L1T unpacker sequence.

@rekovic
Copy link
Contributor Author

rekovic commented Nov 17, 2017

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2017

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24503/console Started: 2017/11/17 15:59

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 17, 2017

A new Pull Request was created by @rekovic for CMSSW_9_4_X.

It involves the following packages:

L1Trigger/Configuration

@cmsbuild, @rekovic, @mulhearn can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

@rekovic
Copy link
Contributor Author

rekovic commented Nov 17, 2017

backport of #21353

@rekovic
Copy link
Contributor Author

rekovic commented Nov 17, 2017

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs after it passes the integration tests and once validation in the development release cycle CMSSW_10_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21352/24503/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2779661
  • DQMHistoTests: Total failures: 104
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2779385
  • DQMHistoTests: Total skipped: 171
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0 KiB( 0 files compared)
  • Checked 107 log files, 8 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

@rekovic is this PR still needed in 94X or can just be closed?

@rekovic
Copy link
Contributor Author

rekovic commented Jul 3, 2018

@fabiocos
Yes, please merge this.

@fabiocos
Copy link
Contributor

fabiocos commented Jul 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/29005/console Started: 2018/07/04 18:35

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21352/29005/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 108
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 2721222
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@fabiocos
Copy link
Contributor

@rekovic sorry, for which studies is this needed?

@fabiocos
Copy link
Contributor

fabiocos commented Aug 7, 2018

hold

pendign a clarification

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2018

Pull request has been put on hold by @fabiocos
They need to issue an unhold command to remove the hold state or L1 can unhold it for all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants