New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General clean-up of the SimG4Core/CustomPhysics library #21462
Conversation
The code-checks are being triggered in jenkins. |
+code-checks |
A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master. It involves the following packages: SimG4Core/CustomPhysics @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar (and backports should be raised in the release meeting by the corresponding L2) |
code-checks |
The code-checks are being triggered in jenkins. |
+code-checks |
+1 |
Some re-design of classes defining CustomParticles is done. It become possible to perform exotic simulation in MT mode.
Extra python fragment Exotica_MT_SIM_cfi.py may be recommended for exotica simulation instead of old Exotica_HSCP_SIM_cfi.py
Code clean-up include implementing of naming convention for header files and one obsolete class is removed.