Added include for Candidate.h to TopProjectorAlgo.h

[Teemperor]

We actually require the definition of Candidate in this header,
so we include the associated header to make this header parsable
on its own.

[Teemperor]

Part of the work going on regarding the C++ modules migration of CMSSW (tracked as issue #15248). This PR is not meant to refactor things, but just to make these headers compile.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21523/2284

[cmsbuild]

A new Pull Request was created by @Teemperor (Raphael Isemann) for master.

It involves the following packages:

CommonTools/ParticleFlow

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@ahinzmann, @jdolen, @rappoccio, @gkasieczka, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/24785/console Started: 2017/11/30 17:47

[cmsbuild]

+1
Tested at: af6a91e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21523/24785/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
a2fb258
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21523/24785/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21523/24785/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21523/24785/summary.html

There are some workflows for which there are errors in the baseline:
10824.0 step 5
The results for the comparisons for these workflows could be incomplete
This means most likely that the IB is having errors in the relvals.The error does NOT come from this pull request

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 26
• DQMHistoTests: Total histograms compared: 2606833
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2606661
• DQMHistoTests: Total skipped: 171
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.14999999999 KiB( 22 files compared)
• Checked 106 log files, 8 edm output root files, 26 DQM output files

[slava77]

similar to #18805 and #21415 the solution should be to include the Candidate.h in CandidateFwd.h and then move CandidateFwd.h to CandidateDefs.h

[slava77]

@Teemperor
ping
please clarify on the status of resolution of #21523 (comment)
Thank you.

[slava77]

[a weekly reminder]
@Teemperor
ping
please clarify on the status of resolution of #21523 (comment)
Thank you.