Put LCT related enums in CSCConstants

[dildick]

Enums MAX_CLCT_BINS, MAX_ALCT_BINS and MAX_LCT_BINS were defined in 3 different places. This PR puts all three in the common class CSCConstants.

Additional enums were created in CSCConstants:

• MAX_CFEBS
• NUM_DISTRIPS_PER_CFEB, NUM_STRIPS_PER_CFEB, NUM_HALF_STRIPS_PER_CFEB
• NUM_PATTERN_WIRES, NUM_PATTERN_STRIPS, NUM_PATTERN_HALFSTRIPS
• MAX_CLCTS_PER_PROCESSOR, MAX_ALCTS_PER_PROCESSOR
• MAX_HALF_STRIP_ME1A_GANGED, MAX_HALF_STRIP_ME1A_UNGANGED, MAX_HALF_STRIP_ME1B
• CLCT_FPGA_LATENCY, ALCT_FPGA_LATENCY
• MAX_NUM_WIRES_ME11.

EDIT:

MAX_CLCT_BINS -> MAX_CLCT_TBINS
MAX_ALCT_BINS -> MAX_ALCT_TBINS
MAX_LCT_BINS -> MAX_LCT_TBINS
NUM_PATTERN_WIRES -> MAX_WIRES_IN_PATTERN
NUM_PATTERN_STRIPS -> MAX_STRIPS_IN_PATTERN
NUM_PATTERN_HALFSTRIPS -> MAX_HALFSTRIPS_IN_PATTERN
MAX_NUM_WIRES_ME11 -> MAX_WIRES_ME11
_LATENCY -> _EMUL_TIME_OFFSET

This PR is part of an effort to document the "magic" numbers in the CSC local trigger. There should be no change in performance.

@tahuang1991

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21650/2445

[cmsbuild]

A new Pull Request was created by @dildick (Sven Dildick) for master.

It involves the following packages:

L1Trigger/CSCCommonTrigger
L1Trigger/CSCTriggerPrimitives

@nsmith-, @cmsbuild, @thomreis, @rekovic can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @ptcox, @valuev, @kreczko this is something you requested to watch as well.
@davidlange6, @slava77 you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.

[cmsbuild]

+1
Tested at: 68364cf
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/24958/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
78a797a
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/24958/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/24958/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/24958/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21650/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2835085
• DQMHistoTests: Total failures: 75
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2834832
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.5499999999 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[dildick]

I implemented following changes after feedback from UCLA folks

MAX_CLCT_BINS -> MAX_CLCT_TBINS
MAX_ALCT_BINS -> MAX_ALCT_TBINS
MAX_LCT_BINS -> MAX_LCT_TBINS
NUM_PATTERN_WIRES -> MAX_WIRES_IN_PATTERN
NUM_PATTERN_STRIPS -> MAX_STRIPS_IN_PATTERN
NUM_PATTERN_HALFSTRIPS -> MAX_HALFSTRIPS_IN_PATTERN
MAX_NUM_WIRES_ME11 -> MAX_WIRES_ME11
_LATENCY -> _EMUL_TIME_OFFSET

That should be it for this PR

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/PR-21650/2538

[cmsbuild]

Pull request #21650 was updated. @nsmith-, @cmsbuild, @thomreis, @rekovic can you please check and sign again.

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25037/console Started: 2017/12/11 22:44

[cmsbuild]

+1
Tested at: c13926b
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/25037/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ef598b6
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/25037/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/25037/git-merge-result

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21650/25037/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21650/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2835241
• DQMHistoTests: Total failures: 75
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2834988
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.909999999843 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[dildick]

@rekovic could you please sign?

[rekovic]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1