Require vertex to have time to use timing cuts in displaced track seeding #21659
Conversation
|
@cmsbuild please test |
|
The code-checks are being triggered in jenkins. |
|
+code-checks |
|
The tests are being triggered in jenkins. |
|
A new Pull Request was created by @lgray (Lindsey Gray) for master. It involves the following packages: RecoVertex/AdaptiveVertexFinder @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready The workflows 1003.0, 1001.0, 1000.0, 140.53, 136.7611, 136.731, 4.22 have different files in step1_dasquery.log than the ones found in the baseline. You may want to check and retrigger the tests if necessary. You can check it in the "files" directory in the results of the comparisons @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
assign upgrade |
|
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
|
@cmsbuild please test running tests for PRs made against the HEAD is not very practical. |
cmsbuild
added
comparison-pending
and removed
comparison-available
tests-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21659/4297 |
|
The tests are being triggered in jenkins. |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
Yep coming soon.
…On Thu, Apr 12, 2018 at 12:45 PM, Slava Krutelyov ***@***.***> wrote:
@lgray <https://github.com/lgray>
please push the same updates to #21193
<#21193>
it is much easier to test in 93X
Please let me know if you can follow up on this.
Thank you.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#21659 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABBMOVcRl0Dv7Ed-wkOrbXyhK2M-Xcarks5tn5KrgaJpZM4Q6MPU>
.
|
|
+1
The changes are only in 20434.0 as expected. Additionally, the tests in #21193 now show no difference in the b-tagging variables (DQM plots) |
|
+1 |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Since #20640 was merged, this is needed to bring master in line with #21193.
Add the requirement that the primary vertex has timing information to use the track time cuts.