Phase2-hgx93 Clean up all the validation classes and unused cfi(cfff) files

[bsunanda]

In view of removing unused HGCal codes

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21734/2625

[cmsbuild]

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

Validation/HGCalValidation

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@vandreev11, @sethzenz, @rovere, @lgray, @cseez, @pfs, @kpedro88 this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[davidlange6]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25134/console Started: 2017/12/16 01:06

[cmsbuild]

+1
Tested at: b3ae72e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21734/25134/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21734/25134/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21734/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 28 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2836825
• DQMHistoTests: Total failures: 806
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2835841
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.08000000003 KiB( 23 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[kpedro88]

@bsunanda can you also suppress the message "No PHGCalInfo"? That one is still present in the matrix logs from this PR.

[cmsbuild]

Pull request #21734 was updated. @perrotta, @civanch, @vazzolini, @kmaeshima, @mdhildreth, @dmitrijus, @cmsbuild, @jfernan2, @slava77, @vanbesien can you please check and sign again.

[bsunanda]

@cmsbuild Please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25144/console Started: 2017/12/17 18:22

[cmsbuild]

+1
Tested at: ab1bd1a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21734/25144/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21734/25144/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins-workarea/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21734/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 32 differences found in the comparisons
• DQMHistoTests: Total files compared: 27
• DQMHistoTests: Total histograms compared: 2836699
• DQMHistoTests: Total failures: 1857
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2834664
• DQMHistoTests: Total skipped: 178
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.670000000107 KiB( 20 files compared)
• Checked 113 log files, 9 edm output root files, 27 DQM output files

[slava77]

+1

for #21734 ab1bd1a

• this is rather tangential to reco, only via Validation/Configuration
• jenkins tests pass and comparisons with baseline show no relevant changes in reco quantities (ignoring the randomness from HCAL M3); there is also a significant reduction in the number of LogWarnings

[civanch]

+1

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[davidlange6]

+1