Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert making a copy of RefCore in RefVector calls #21772

Merged
merged 2 commits into from Dec 22, 2017
Merged

Revert making a copy of RefCore in RefVector calls #21772

merged 2 commits into from Dec 22, 2017

Commits on Dec 22, 2017

  1. Revert making a copy of RefCore in RefVector calls 

    The clang check change made previously incorrectly converted a needed copy to just be a const ref. This ultimately lead to a threading race-condition when that code was called.
    @Dr15Jones
    Dr15Jones committed Dec 22, 2017
    Copy the full SHA
    36e9133 View commit details
    Browse the repository at this point in the history

  2. Stop clang-tidy from making change 

    clang-tidy incorrectly wants to change the copy into a const &. Adding the comment will prevent clang-tidy from affecting those lines.
    @Dr15Jones
    Dr15Jones committed Dec 22, 2017
    Copy the full SHA
    29eb96a View commit details
    Browse the repository at this point in the history