Dedicated Timing Plots - New Settings for uGT and Eta/Phi Map - L1T & Online DQM #21793

ghost · 2017-12-30T12:36:18Z

My task in JIRA is : ([https://its.cern.ch/jira/browse/CMSLITDPG-165]).

First of all, I would like to mention that I added a new and more convenient way to implement the necessary algorithm trigger bits (L1_FirstCollisionInTrain, L1_LastCollisionInTrain) for producing pre- post- firing plots using them as parameters for the first bunch, last bunch and isolated bunch. After that, I produced a new module for producing pre- post- firing plots with a second way using eta/phi map for L1T objects (muon, jet, tau, egamma, MET) for every BX as well as for the first bunch, last bunch and isolated bunch.

cmsbuild · 2017-12-30T12:36:46Z

The code-checks are being triggered in jenkins.

cmsbuild · 2017-12-30T12:39:07Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21793/2767

cmsbuild · 2017-12-30T12:39:36Z

A new Pull Request was created by @dtsitson for master.

It involves the following packages:

DQM/L1TMonitor

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

jfernan2 · 2018-01-02T21:28:09Z

please test

cmsbuild · 2018-01-02T21:30:26Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25299/console Started: 2018/01/02 22:31

cmsbuild · 2018-01-02T22:53:26Z

-1

Tested at: f8de97a

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21793/25299/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

RelVals:

When I ran the RelVals I found an error in the following worklfows:
4.22 step2

runTheMatrix-results/4.22_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC/step2_RunCosmics2011A+RunCosmics2011A+RECOCOSD+ALCACOSD+SKIMCOSD+HARVESTDC.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

8.0 step3

runTheMatrix-results/8.0_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS/step3_BeamHalo+BeamHalo+DIGICOS+RECOCOS+ALCABH+HARVESTCOS.log

5.1 step2

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step2_TTbar+TTbarFS+HARVESTFS.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

135.4 step2

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step2_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

140.53 step2

runTheMatrix-results/140.53_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI/step2_RunHI2011+RunHI2011+RECOHID11+HARVESTDHI.log

1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017/step2_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017.log

7.3 step3

runTheMatrix-results/7.3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17/step3_CosmicsSPLoose_UP17+CosmicsSPLoose_UP17+DIGICOS_UP17+RECOCOS_UP17+ALCACOS_UP17+HARVESTCOS_UP17.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

cmsbuild · 2018-01-02T22:53:28Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

thomreis · 2018-01-08T17:58:31Z

Hi @dtsitson
how is this PR related to #21744 ? Have the comments there all been addressed?

ghost · 2018-01-08T22:04:00Z

No, I did not follow all the comments. I proceed to that work slowly. I recreated a new PR (CMSSW_10_0_X) in order to fix the conflicts!

thomreis · 2018-01-09T07:29:55Z

Please implement the comments here and close #21744 in that case.
The tests are also failing because you changed more than the necessary parts in DQM/L1TMonitor/python/L1TStage2_cff.py and reverted some changes made by others by mistake.

cmsbuild · 2018-01-13T15:02:05Z

Pull request #21793 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

thomreis · 2018-01-13T16:52:59Z

please test

cmsbuild · 2018-01-13T16:53:19Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25425/console Started: 2018/01/13 17:54

cmsbuild · 2018-01-13T18:31:13Z

+1
Tested at: 21bd74e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21793/25425/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
be52eba
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21793/25425/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21793/25425/git-merge-result

cmsbuild · 2018-01-13T18:31:15Z

Comparison job queued.

cmsbuild · 2018-01-13T19:04:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21793/25425/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21793/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 10 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2467599
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2467426
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1566.32 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

thomreis · 2018-01-15T10:05:17Z

This adds new DQM histograms. Therefore, the memory increase is expected.

dmitrijus · 2018-01-17T15:03:04Z

Hi, @thomreis

How is this related to #21844 ?
Which one should be merged first?

thomreis · 2018-01-17T15:05:47Z

Hi @dmitrijus
better to merge this one first. I'll deal with eventual conflicts in #21844

dmitrijus · 2018-01-18T11:36:14Z

+1

cmsbuild · 2018-01-18T11:36:36Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

thomreis · 2018-01-24T09:31:21Z

@davidlange6 can this be reviewed/merged please?

fabiocos · 2018-01-24T21:53:06Z

+1

Additional Options for uGT & New Timing Plots using eta/phi map

f8de97a

cmsbuild added this to the CMSSW_10_0_X milestone Dec 30, 2017

cmsbuild added code-checks-pending comparison-pending dqm-pending orp-pending pending-signatures tests-pending labels Dec 30, 2017

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 30, 2017

cmsbuild added tests-started and removed tests-pending labels Jan 2, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 2, 2018

Additional Options for uGT & New Timing Plots using eta/phi map

060637c

cmsbuild removed code-checks-approved comparison-notrun tests-rejected labels Jan 9, 2018

cmsbuild added the code-checks-approved label Jan 13, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 13, 2018

cmsbuild added tests-approved and removed tests-started labels Jan 13, 2018

cmsbuild added comparison-available and removed comparison-pending labels Jan 13, 2018

cmsbuild removed dqm-pending pending-signatures labels Jan 18, 2018

cmsbuild added dqm-approved fully-signed labels Jan 18, 2018

smuzaffar modified the milestones: CMSSW_10_0_X, CMSSW_10_1_X Jan 24, 2018

cmsbuild added orp-approved and removed orp-pending labels Jan 24, 2018

cmsbuild merged commit e9a0f9f into cms-sw:master Jan 24, 2018

ghost mentioned this pull request Jan 31, 2018

Dedicated Timing Plots - New Settings for uGT and Eta/Phi Map - L1T & Online DQM - CMSSW - 100X #22052

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dedicated Timing Plots - New Settings for uGT and Eta/Phi Map - L1T & Online DQM #21793

Dedicated Timing Plots - New Settings for uGT and Eta/Phi Map - L1T & Online DQM #21793

ghost commented Dec 30, 2017

cmsbuild commented Dec 30, 2017

cmsbuild commented Dec 30, 2017

cmsbuild commented Dec 30, 2017

jfernan2 commented Jan 2, 2018

cmsbuild commented Jan 2, 2018 •

edited

cmsbuild commented Jan 2, 2018

cmsbuild commented Jan 2, 2018

thomreis commented Jan 8, 2018

ghost commented Jan 8, 2018

thomreis commented Jan 9, 2018

cmsbuild commented Jan 13, 2018

thomreis commented Jan 13, 2018

cmsbuild commented Jan 13, 2018 •

edited

cmsbuild commented Jan 13, 2018

cmsbuild commented Jan 13, 2018

cmsbuild commented Jan 13, 2018

thomreis commented Jan 15, 2018

dmitrijus commented Jan 17, 2018

thomreis commented Jan 17, 2018

dmitrijus commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

thomreis commented Jan 24, 2018

fabiocos commented Jan 24, 2018

Dedicated Timing Plots - New Settings for uGT and Eta/Phi Map - L1T & Online DQM #21793

Dedicated Timing Plots - New Settings for uGT and Eta/Phi Map - L1T & Online DQM #21793

Conversation

ghost commented Dec 30, 2017

cmsbuild commented Dec 30, 2017

cmsbuild commented Dec 30, 2017

cmsbuild commented Dec 30, 2017

jfernan2 commented Jan 2, 2018

cmsbuild commented Jan 2, 2018 • edited

cmsbuild commented Jan 2, 2018

cmsbuild commented Jan 2, 2018

thomreis commented Jan 8, 2018

ghost commented Jan 8, 2018

thomreis commented Jan 9, 2018

cmsbuild commented Jan 13, 2018

thomreis commented Jan 13, 2018

cmsbuild commented Jan 13, 2018 • edited

cmsbuild commented Jan 13, 2018

cmsbuild commented Jan 13, 2018

cmsbuild commented Jan 13, 2018

thomreis commented Jan 15, 2018

dmitrijus commented Jan 17, 2018

thomreis commented Jan 17, 2018

dmitrijus commented Jan 18, 2018

cmsbuild commented Jan 18, 2018

thomreis commented Jan 24, 2018

fabiocos commented Jan 24, 2018

cmsbuild commented Jan 2, 2018 •

edited

cmsbuild commented Jan 13, 2018 •

edited