CPPFDigis dataformat and RPC unpacker #21802

jhgoh · 2018-01-04T04:55:56Z

This PR adds new CPPFDigis dataformat and RPC unpacker with related codes,
most contributions by @abrinke1 for the CPPFDigis and @fthyssen for the RPC unpacker part.

We would like to include the new CPPFDigis but not enable by default - as the first step of RPC-CPPF integration and move to next steps.

Presentation at RECO/AT 2018.01.13

@abrinke1 @rekovic @mileva

cmsbuild · 2018-01-04T04:56:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-01-04T04:58:29Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21802/2787

cmsbuild · 2018-01-04T04:58:48Z

A new Pull Request was created by @jhgoh (Junghwan John Goh) for master.

It involves the following packages:

CondTools/RPC
DataFormats/L1TMuon
DataFormats/RPCDigi
EventFilter/RPCRawToDigi

@perrotta, @cmsbuild, @civanch, @mdhildreth, @nsmith-, @rekovic, @thomreis, @slava77, @ggovi can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @mmusich, @rovere, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

civanch · 2018-01-04T06:17:41Z

please test

cmsbuild · 2018-01-04T06:18:03Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25310/console Started: 2018/01/04 07:18

cmsbuild · 2018-01-04T06:23:53Z

-1

Tested at: 2601ab4

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f89c071
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/25310/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/25310/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/25310/summary.html

I found follow errors while testing this PR

Failed tests: Build ClangBuild

Build:

I found an error when building:

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpackerFactory.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCRawToDigi.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCReadOutMappingWithFastSearch.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc: In member function 'virtual void RPCTwinMuxRawToDigi::produce(edm::Event&, const edm::EventSetup&)':
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:88:27: error: 'fed_event_' is not a member of 'RPCAMCLinkCounters'
             counters->add(RPCAMCLinkCounters::fed_event_, RPCAMCLink(fed, RPCAMCLink::wildcard_));
                           ^~~~~~~~~~~~~~~~~~
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:136:35: error: 'fed_trailer_crc_mismatch_' is not a member of 'RPCAMCLinkCounters'
                     counters->add(RPCAMCLinkCounters::fed_trailer_crc_mismatch_, RPCAMCLink(fed, RPCAMCLink::wildcard_));
                                   ^~~~~~~~~~~~~~~~~~

Clang:

I found a compilation error while trying to compile with clang:
I used this command:
scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'

>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpacker.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCUnpackerFactory.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCAMCRawToDigi.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCReadOutMappingWithFastSearch.cc 
>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/SealModule.cc 
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:88:47: error: no member named 'fed_event_' in 'RPCAMCLinkCounters'
            counters->add(RPCAMCLinkCounters::fed_event_, RPCAMCLink(fed, RPCAMCLink::wildcard_));
                          ~~~~~~~~~~~~~~~~~~~~^
/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_10_0_X_2018-01-03-2300/src/EventFilter/RPCRawToDigi/plugins/RPCTwinMuxRawToDigi.cc:136:55: error: no member named 'fed_trailer_crc_mismatch_' in 'RPCAMCLinkCounters'
                    counters->add(RPCAMCLinkCounters::fed_trailer_crc_mismatch_, RPCAMCLink(fed, RPCAMCLink::wildcard_));
                                  ~~~~~~~~~~~~~~~~~~~~^

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
f89c071
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/25310/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/25310/git-merge-result

cmsbuild · 2018-01-04T06:23:55Z

Comparison not run due to Build errors (RelVals and Igprof tests were also skipped)

jhgoh · 2018-01-04T07:44:10Z

fixed build error

cmsbuild · 2018-02-16T13:50:10Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26126/console Started: 2018/02/16 14:50

cmsbuild · 2018-02-16T15:55:56Z

+1
Tested at: db975dd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/26126/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
657a4d8
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/26126/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/26126/git-merge-result

cmsbuild · 2018-02-16T15:55:59Z

Comparison job queued.

cmsbuild · 2018-02-16T17:40:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21802/26126/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 27
DQMHistoTests: Total histograms compared: 2465360
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2465190
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.56999999988 KiB( 22 files compared)
Checked 111 log files, 9 edm output root files, 27 DQM output files

civanch · 2018-02-17T15:55:45Z

+1

perrotta · 2018-02-18T17:59:39Z

+1

This PR adds the necessary dataformat and unpacker for CPPF/RPC, in view of the next developents which needs it
It is not yet testable on MC, but on data objects are created, and their content was checked and validated as reported in CPPFDigis dataformat and RPC unpacker #21802 (comment)

jhgoh · 2018-02-19T17:15:03Z

@perrotta thank you for all the reviews. we can continue to the next stage based on this PR.

ggovi · 2018-02-20T09:08:36Z

+1

rekovic · 2018-02-20T16:46:43Z

+1

cmsbuild · 2018-02-20T16:47:04Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-02-21T08:40:58Z

+1

cmsbuild added this to the CMSSW_10_0_X milestone Jan 4, 2018

cmsbuild added code-checks-pending comparison-pending db-pending l1-pending orp-pending pending-signatures reconstruction-pending simulation-pending tests-pending labels Jan 4, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 4, 2018

cmsbuild added tests-started and removed tests-pending labels Jan 4, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Jan 4, 2018

cmsbuild added code-checks-pending and removed code-checks-approved comparison-notrun tests-rejected labels Jan 4, 2018

cmsbuild added tests-started and removed tests-pending labels Feb 16, 2018

cmsbuild added tests-approved and removed tests-started labels Feb 16, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 16, 2018

cmsbuild added simulation-approved and removed simulation-pending labels Feb 17, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Feb 18, 2018

cmsbuild added db-approved and removed db-pending labels Feb 20, 2018

cmsbuild added fully-signed l1-approved and removed l1-pending pending-signatures labels Feb 20, 2018

cmsbuild added orp-approved and removed orp-pending labels Feb 21, 2018

cmsbuild merged commit 86ee8ea into cms-sw:master Feb 21, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CPPFDigis dataformat and RPC unpacker #21802

CPPFDigis dataformat and RPC unpacker #21802

jhgoh commented Jan 4, 2018 •

edited

cmsbuild commented Jan 4, 2018

cmsbuild commented Jan 4, 2018

cmsbuild commented Jan 4, 2018

civanch commented Jan 4, 2018

cmsbuild commented Jan 4, 2018 •

edited

cmsbuild commented Jan 4, 2018

cmsbuild commented Jan 4, 2018

jhgoh commented Jan 4, 2018

cmsbuild commented Feb 16, 2018 •

edited

cmsbuild commented Feb 16, 2018

cmsbuild commented Feb 16, 2018

cmsbuild commented Feb 16, 2018

civanch commented Feb 17, 2018

perrotta commented Feb 18, 2018

jhgoh commented Feb 19, 2018

ggovi commented Feb 20, 2018

rekovic commented Feb 20, 2018

cmsbuild commented Feb 20, 2018

fabiocos commented Feb 21, 2018

CPPFDigis dataformat and RPC unpacker #21802

CPPFDigis dataformat and RPC unpacker #21802

Conversation

jhgoh commented Jan 4, 2018 • edited

cmsbuild commented Jan 4, 2018

cmsbuild commented Jan 4, 2018

cmsbuild commented Jan 4, 2018

civanch commented Jan 4, 2018

cmsbuild commented Jan 4, 2018 • edited

cmsbuild commented Jan 4, 2018

cmsbuild commented Jan 4, 2018

jhgoh commented Jan 4, 2018

cmsbuild commented Feb 16, 2018 • edited

cmsbuild commented Feb 16, 2018

cmsbuild commented Feb 16, 2018

cmsbuild commented Feb 16, 2018

civanch commented Feb 17, 2018

perrotta commented Feb 18, 2018

jhgoh commented Feb 19, 2018

ggovi commented Feb 20, 2018

rekovic commented Feb 20, 2018

cmsbuild commented Feb 20, 2018

fabiocos commented Feb 21, 2018

jhgoh commented Jan 4, 2018 •

edited

cmsbuild commented Jan 4, 2018 •

edited

cmsbuild commented Feb 16, 2018 •

edited