Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NanoAOD Update #21827

Merged
merged 25 commits into from Jan 12, 2018
Merged

NanoAOD Update #21827

merged 25 commits into from Jan 12, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jan 11, 2018 •
edited

This update contains up to PR cms-nanoAOD#91

  • L1 objects update
  • ttbar categorization flags
  • updates in PDF/LHE stuff
  • genparticles status flags

tstreble and others added 25 commits November 24, 2017 17:44
@tstreble @arizzi
Updated L1 information using dedicated MINIAOD collections
9102530
@tstreble @arizzi
Updated nanoDQM
291b136
@tstreble @arizzi
Changed precision of some TrigObj branches
8691c80
@tstreble @arizzi
Added l1charge for L1Muons
c4f1565
@tstreble @arizzi
Updated nanoDQM
6130ddb
@tstreble @arizzi
Updated nanoDQM
d902a03
@arizzi
remove trailing spaces
56b9810
@tstreble @arizzi
Implemented self-cleaning of TrigObj
dad6e7b
@tstreble @arizzi
Indentation fix
6e68496
@kschweiger @gpetruc
Added ttbar categorization
2b31c43
@kschweiger @gpetruc
Correct module postion in sequence for all eras assured
a004817
@kschweiger @gpetruc
Update nano_cfg.py
1db81d0
@kschweiger @gpetruc
Adressed issues
5b3059b
@kschweiger @gpetruc
Split sequence; changed era modification
03358ab
@gpetruc
recover change that in merge commit, that was missed by the rebase
6e9ba92
@gpetruc
Fix DQM
3ffe8b6
@gpetruc
Catch some more formats of LHE weight headers.
9ac0d9e 
Tested that it parses correctly the all following Fall17 files
  /store/mc/RunIIFall17MiniAOD/DY2JetsToLL_M-50_TuneCP5_13TeV-madgraphMLM-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/30000/06DF841B-D6D8-E711-8E49-02163E014665.root
  /store/mc/RunIIFall17MiniAOD/TTToSemiLeptonic_TuneCP5_PSweights_13TeV-powheg-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/60000/A0D71AEE-13E1-E711-B3C9-FA163E629498.root
  /store/mc/RunIIFall17MiniAOD/ST_s-channel_4f_leptonDecays_TuneCP5_13TeV-amcatnlo-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/70000/E8E03C84-32E1-E711-AFA8-FA163EAC4CED.root
  /store/mc/RunIIFall17MiniAOD/DYJetsToLL_M-50_TuneCP5_13TeV-amcatnloFXFX-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/50000/0CAD1964-6FD9-E711-97C4-FA163EE0F5F8.root
  /store/mc/RunIIFall17MiniAOD/QCD_HT700to1000_BGenFilter_TuneCP5_13TeV-madgraph-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v2/60000/0AE723BD-C0D8-E711-8606-FA163E3CBF20.root
  /store/mc/RunIIFall17MiniAOD/ST_t-channel_antitop_4f_inclusiveDecays_TuneCP5_13TeV-powhegV2-madspin-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/70000/C6218E8C-0FE1-E711-88EB-FA163EF3D9F3.root
  /store/mc/RunIIFall17MiniAOD/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/MINIAODSIM/94X_mc2017_realistic_v10-v1/40000/6820A6D0-C9DE-E711-BF40-009C02AAB484.root

Tested also Summer16
  /store/mc/RunIISummer16MiniAODv2/DYJetsToLL_M-50_TuneCUETP8M1_13TeV-madgraphMLM-pythia8/MINIAODSIM/PUMoriond17_80X_mcRun2_asymptotic_2016_TrancheIV_v6_ext1-v2/120000/02A210D6-F5C3-E611-B570-008CFA197BD4.root
@gpetruc
one more case
999ccfd
@gpetruc
Fix docstring for scale and pdf weights
8dcfe64
@gpetruc
Fix cases where the central PDF weight is not included, only the vari…
24836df 
…ations (happens in 92X MC)
@rappoccio @gpetruc
Adding other LO PDF info because it can be still used by pythia,herwi…
2b38478 
…g,etc
@rappoccio @gpetruc
Update globals_cff.py
fc068f5
@gpetruc
Merge CMSSW_10_0_0_pre2
4792ab0
@l-cadamuro @arizzi
gen particles flags added
7ea3ad5
@l-cadamuro @arizzi
nano dqm
523751f
@cmsbuild cmsbuild added this to the CMSSW_10_0_X milestone Jan 11, 2018
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@arizzi arizzi mentioned this pull request Jan 11, 2018
Merged
@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21827/2840

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @arizzi for master.

It involves the following packages:

PhysicsTools/NanoAOD

@cmsbuild, @monttj can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jan 11, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 11, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25378/console Started: 2018/01/11 15:22

@cmsbuild
Copy link
Contributor

+1
Tested at: 523751f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21827/25383/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
4792ab0
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21827/25383/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21827/25383/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21827/25383/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21827/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467710
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467540
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.19000000004 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merged

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 966667e into cms-sw:master Jan 12, 2018
cmsbuild added a commit that referenced this pull request Jan 16, 2018
@cmsbuild
Merge pull request #21828 from cms-nanoAOD/master
b9efd01 
NanoAOD Update (94X version of #21827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved comparison-available orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_10_0_X
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@arizzi @cmsbuild @slava77 @fabiocos @tstreble @kschweiger @gpetruc @rappoccio @l-cadamuro