New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce an alias for DQMEDAnalyzer #21871
Introduce an alias for DQMEDAnalyzer #21871
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-21871/2918 |
A new Pull Request was created by @schneiml (Marcel Schneider) for master. It involves the following packages: Alignment/CommonAlignmentProducer @ghellwig, @lveldere, @ianna, @kpedro88, @nsmith-, @rekovic, @thomreis, @vanbesien, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @Dr15Jones, @ssekmen, @mdhildreth, @jfernan2, @cerminar, @slava77, @Martin-Grunewald, @efeyazgan, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @dmitrijus, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
+1 |
@perrozzi @efeyazgan could you please check and sign in case? |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@Dr15Jones this is a massive code migration wrt to the old python syntax, I would like your final confirmation you are ok with it before moving forward (possibly in next IB already) |
+1 |
+1 @Dr15Jones ok, thanks, I let this go tonight |
This branch modifies all DQM-related config files to use an alias
DQMEDAnalyzer
instead ofcms.EDAnalyzer
to declare theirDQMEDAnalyzer
s. This is a first step to changing the base ofDQMEDAnalyzer
(likely toEDProducer
oredm::one::EDProducer
), which can then be used to run DQM unscheduled, improve concurrency and reduce memory consumption.Right now, this is a no-op and should not do anything, since the alias still points to
cms.EDAnalyzer
and the base class is not changed. The final conversion likely has to wait for an additional feature in the framework (thanks @Dr15Jones !).Caveats:
DQMEDAnalyzer
s came form cmssdt DXR, which is CMSSW_9_4. I might have missed newer modules.DQMEDAnalyzer
s, including those that are not typical online/offline/relval DQM. In case you use them for other purposes, please contact core DQM that we know about you. Otherwise, we will likely break your application going ahead.This is related to issue #15866. It is similar to #18751 in terms of changes.