Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce an alias for DQMEDAnalyzer #21871

Merged

Conversation

schneiml
Copy link
Contributor

This branch modifies all DQM-related config files to use an alias DQMEDAnalyzer instead of cms.EDAnalyzer to declare their DQMEDAnalyzers. This is a first step to changing the base of DQMEDAnalyzer (likely to EDProducer or edm::one::EDProducer), which can then be used to run DQM unscheduled, improve concurrency and reduce memory consumption.

Right now, this is a no-op and should not do anything, since the alias still points to cms.EDAnalyzer and the base class is not changed. The final conversion likely has to wait for an additional feature in the framework (thanks @Dr15Jones !).

Caveats:

  • These changes were obviously done in an automated way, and not fully validated by hand.
  • The list of DQMEDAnalyzers came form cmssdt DXR, which is CMSSW_9_4. I might have missed newer modules.
  • This PR will very quickly conflict with others. I can redo the changes fairly easily in that case, but this is the motivation to separate it from the functional changes.
  • This PR touches all DQMEDAnalyzers, including those that are not typical online/offline/relval DQM. In case you use them for other purposes, please contact core DQM that we know about you. Otherwise, we will likely break your application going ahead.

This is related to issue #15866. It is similar to #18751 in terms of changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @schneiml (Marcel Schneider) for master.

It involves the following packages:

Alignment/CommonAlignmentProducer
CalibMuon/DTCalibration
Calibration/EcalCalibAlgos
Calibration/TkAlCaRecoProducers
DQM/BeamMonitor
DQM/CSCMonitorModule
DQM/CTPPS
DQM/CastorMonitor
DQM/DTMonitorModule
DQM/DataScouting
DQM/EcalMonitorTasks
DQM/EcalPreshowerMonitorClient
DQM/EcalPreshowerMonitorModule
DQM/HLTEvF
DQM/HLXMonitor
DQM/Integration
DQM/L1TMonitor
DQM/Physics
DQM/PixelLumi
DQM/RCTMonitor
DQM/RPCMonitorClient
DQM/RPCMonitorDigi
DQM/SiPixelCommon
DQM/SiPixelMonitorCluster
DQM/SiPixelMonitorDigi
DQM/SiPixelMonitorRawData
DQM/SiPixelMonitorRecHit
DQM/SiPixelMonitorTrack
DQM/SiPixelPhase1Clusters
DQM/SiPixelPhase1Common
DQM/SiPixelPhase1Digis
DQM/SiPixelPhase1RawData
DQM/SiPixelPhase1RecHits
DQM/SiPixelPhase1TrackClusters
DQM/SiPixelPhase1TrackEfficiency
DQM/SiPixelPhase1TrackResiduals
DQM/SiStripMonitorClient
DQM/SiStripMonitorCluster
DQM/SiStripMonitorDigi
DQM/SiStripMonitorHardware
DQM/SiStripMonitorPedestals
DQM/TrackingMonitor
DQM/TrackingMonitorSource
DQM/TrigXMonitor
DQMOffline/Alignment
DQMOffline/CalibCalo
DQMOffline/CalibMuon
DQMOffline/EGamma
DQMOffline/Ecal
DQMOffline/Hcal
DQMOffline/JetMET
DQMOffline/L1Trigger
DQMOffline/Lumi
DQMOffline/Muon
DQMOffline/PFTau
DQMOffline/RecoB
DQMOffline/Trigger
DQMServices/Components
DQMServices/Core
DQMServices/Examples
FastSimulation/Calorimetry
HLTriggerOffline/B2G
HLTriggerOffline/Btag
HLTriggerOffline/Egamma
HLTriggerOffline/HeavyFlavor
HLTriggerOffline/Higgs
HLTriggerOffline/JetMET
HLTriggerOffline/Muon
HLTriggerOffline/SMP
HLTriggerOffline/SUSYBSM
HLTriggerOffline/Tau
HLTriggerOffline/Top
PhysicsTools/Heppy
RecoEgamma/Examples
SimG4CMS/EcalTestBeam
SimTracker/SiPhase2Digitizer
Validation/CSCRecHits
Validation/CaloTowers
Validation/EcalClusters
Validation/EcalDigis
Validation/EcalRecHits
Validation/EventGenerator
Validation/Geometry
Validation/GlobalDigis
Validation/GlobalHits
Validation/GlobalRecHits
Validation/HGCalValidation
Validation/HcalDigis
Validation/HcalHits
Validation/HcalRecHits
Validation/L1T
Validation/Mixing
Validation/MuonCSCDigis
Validation/MuonDTDigis
Validation/MuonGEMDigis
Validation/MuonGEMHits
Validation/MuonGEMRecHits
Validation/MuonHits
Validation/MuonIdentification
Validation/MuonIsolation
Validation/MuonME0Validation
Validation/MuonRPCDigis
Validation/RPCRecHits
Validation/RecoB
Validation/RecoEgamma
Validation/RecoHI
Validation/RecoJets
Validation/RecoMuon
Validation/RecoTrack
Validation/RecoVertex
Validation/SiPixelPhase1DigisV
Validation/SiPixelPhase1HitsV
Validation/SiPixelPhase1RecHitsV
Validation/SiPixelPhase1TrackClustersV
Validation/SiPixelPhase1TrackingParticleV
Validation/TrackerDigis
Validation/TrackerHits
Validation/TrackerRecHits
Validation/TrackingMCTruth

@ghellwig, @lveldere, @ianna, @kpedro88, @nsmith-, @rekovic, @thomreis, @vanbesien, @perrotta, @civanch, @monttj, @silviodonato, @cmsbuild, @fwyzard, @Dr15Jones, @ssekmen, @mdhildreth, @jfernan2, @cerminar, @slava77, @Martin-Grunewald, @efeyazgan, @vazzolini, @kmaeshima, @arunhep, @perrozzi, @dmitrijus, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@ghellwig, @rappoccio, @felicepantaleo, @jainshilpi, @abbiendi, @TaiSakuma, @kpedro88, @argiro, @Martin-Grunewald, @bsunanda, @imarches, @pfs, @thomreis, @tlampen, @ahinzmann, @lgray, @threus, @mmusich, @seemasharmafnal, @venturia, @acimmino, @pakhotin, @mmarionncern, @kreczko, @hdelanno, @calderona, @makortel, @acaudron, @sdevissc, @jhgoh, @varuns23, @jdolen, @HuguesBrun, @drkovalskyi, @ferencek, @trocino, @rociovilar, @vandreev11, @Sam-Harper, @barvic, @ptcox, @kkrajczar, @GiacomoSguazzoni, @tocheng, @VinInn, @cseez, @bellan, @nhanvtran, @gkasieczka, @rovere, @schoef, @mschrode, @idebruyn, @ebrondol, @sethzenz, @mtosi, @dgulhan, @jdamgov, @batinkov, @swertz, @battibass, @JyothsnaKomaragiri, @mverzett, @rylanC24, @wmtford, @cbernet, @matt-komm, @mariadalfonso, @pvmulder, @folguera, @fioriNTU this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ghellwig
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 17, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25489/console Started: 2018/01/17 11:18

@slava77
Copy link
Contributor

slava77 commented Jan 19, 2018

+1

for #21871 d14f997

  • this is somewhat tangential to reco. The only file in the reco category is RecoEgamma/Examples/python/electronAnalyzer_cfi.py
  • jenkins tests pass and comparisons show no differences as expected

@civanch
Copy link
Contributor

civanch commented Jan 20, 2018

+1

@dmitrijus
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

@perrozzi @efeyazgan could you please check and sign in case?

@efeyazgan
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@Dr15Jones this is a massive code migration wrt to the old python syntax, I would like your final confirmation you are ok with it before moving forward (possibly in next IB already)

@Dr15Jones
Copy link
Contributor

+1
@fabiocos this is just like the DQMEDHarvester change that was made last year. The DQM convenors did discuss this with the Framework team before making the change.

@fabiocos
Copy link
Contributor

+1

@Dr15Jones ok, thanks, I let this go tonight

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment