Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an accessor for groomed jet mass in 10.0.x #21944

Merged
merged 2 commits into from Feb 1, 2018

Conversation

arizzi
Copy link
Contributor

@arizzi arizzi commented Jan 24, 2018

The JME recommendations for groomed masses changed since we implemented miniaod, so this adds some accessors to take the invariant mass of all groomed subjets, which gives the groomed jet mass.

This is also planned to be implemented in nanoaod. @rappoccio @gpetruc

Same as:
#21901 #21902

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2018

A new Pull Request was created by @arizzi for CMSSW_10_0_X.

It involves the following packages:

DataFormats/PatCandidates

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gpetruc, @gouskos, @rovere, @cbernet this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@slava77
Copy link
Contributor

slava77 commented Jan 24, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 24, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25603/console Started: 2018/01/24 17:30

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-21944/25603/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-21944/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 26
  • DQMHistoTests: Total histograms compared: 2467599
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2467429
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.16999999998 KiB( 22 files compared)
  • Checked 110 log files, 9 edm output root files, 26 DQM output files

@slava77
Copy link
Contributor

slava77 commented Jan 24, 2018

backport of #21902

@slava77
Copy link
Contributor

slava77 commented Jan 24, 2018

+1

for #21944 0e39d13

@arizzi
Copy link
Contributor Author

arizzi commented Jan 31, 2018

@fabiocos if we want 10.0.X to become the analysis release (e.g. support NANOAOD) this version of the additional pat::Jet accessors PR should be merged too.

@fabiocos
Copy link
Contributor

fabiocos commented Feb 1, 2018

merge

@cmsbuild cmsbuild merged commit e925ce4 into cms-sw:CMSSW_10_0_X Feb 1, 2018
@rappoccio rappoccio deleted the patjet_groomedmass_10x branch December 5, 2019 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants