Have TTreeCache work with EmbeddedRootSource #22068
Conversation
The EmbeddedRootSource calls different functions of RootFile and RootTree. This was causing it to not properly use the TTreeCache. Now we will use the TTreeCache in that case and properly handle the case where we start reading near the end of the file and then jump back to the beginning before training has completed.
|
@bbockelm here is the fix |
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22068/3186 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: IOPool/Input @cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
The tests are being triggered in jenkins. |
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
The EmbeddedRootSource calls different functions of RootFile and
RootTree. This was causing it to not properly use the TTreeCache.
Now we will use the TTreeCache in that case and properly handle
the case where we start reading near the end of the file and then
jump back to the beginning before training has completed.