Adding capability to write out Ptrs in JetConstituentSelector #22092

rappoccio · 2018-02-02T14:09:15Z

In order to recluster AK8 jets from MINIAOD (*), we need to write out the jet constituents in a way that can be easily read out. This adds the capability to write out Ptrs and appropriate unpacking of AK8 jets. This should not affect existing workflows. Backports incoming.

(*) This is often needed for JMAR studies. There will also be an upcoming workflow for JMAR development with nanoaod.

cmsbuild · 2018-02-02T14:09:33Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-02-02T14:11:44Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22092/3216

cmsbuild · 2018-02-02T14:12:01Z

A new Pull Request was created by @rappoccio for master.

It involves the following packages:

CommonTools/RecoAlgos
DataFormats/PatCandidates

@perrotta, @cmsbuild, @monttj, @slava77 can you please review it and eventually sign? Thanks.
@gouskos, @jdolen, @makortel, @abbiendi, @rovere, @ahinzmann, @gkasieczka, @jhgoh, @cbernet, @gpetruc this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2018-02-02T14:46:03Z

CommonTools/RecoAlgos/plugins/JetConstituentSelector.cc

  JetConstituentSelector(edm::ParameterSet const& params) :
    srcToken_{consumes<edm::View<T>>(params.getParameter<edm::InputTag>("src"))},
-    selector_{params.getParameter<std::string>("cut")}
+    selector_{params.getParameter<std::string>("cut")},
+    unpackAK8_{params.existsAs<bool>("unpackAK8") ? params.getParameter<bool>("unpackAK8") : false}


Please, add a "false" as default in the fillDescriptions() method, and get rid of the existsAs here

Won't that affect existing workflows though? If they don't have the parameter they will need to add it. (Or is adding "false" as a default sufficient?)

Adding "false" as default in the parameterSetDescription insures that whenever the parameter is missing the default value is assigned.

Which is the same as you are doing now, but a bit cleaner from the point of view of the code.

existsAs is strongly discouraged and exceptions to use it are still possible only for plugins.
This is not the case for this producer.
So, I think that fillDescriptions should be added.

OK I will fix it. It looks like there are some matrix failures for some reason, I will fix those too.

davidlange6 · 2018-02-02T17:31:03Z

please test

cmsbuild · 2018-02-02T17:31:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25874/console Started: 2018/02/02 18:31

cmsbuild · 2018-02-02T18:30:45Z

-1

Tested at: 3273fce

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22092/25874/summary.html

I found follow errors while testing this PR

Failed tests: RelVals AddOn

RelVals:

When I ran the RelVals I found an error in the following worklfows:
5.1 step1

runTheMatrix-results/5.1_TTbar+TTbarFS+HARVESTFS/step1_TTbar+TTbarFS+HARVESTFS.log

4.53 step3

runTheMatrix-results/4.53_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT/step3_RunPhoton2012B+RunPhoton2012B+HLTD+RECODR1reHLT+HARVESTDR1reHLT.log

135.4 step1

runTheMatrix-results/135.4_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS/step1_ZEE_13+ZEEFS_13+HARVESTUP15FS+MINIAODMCUP15FS.log

136.7611 step2

runTheMatrix-results/136.7611_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM/step2_RunJetHT2016E_reminiaod+RunJetHT2016E_reminiaod+REMINIAOD_data2016_HIPM+HARVESTDR2_REMINIAOD_data2016_HIPM.log

136.731 step3

runTheMatrix-results/136.731_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2/step3_RunSinglePh2016B+RunSinglePh2016B+HLTDR2_2016+RECODR2_2016reHLT_skimSinglePh_HIPM+HARVESTDR2.log

136.788 step3

runTheMatrix-results/136.788_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017/step3_RunSinglePh2017B+RunSinglePh2017B+HLTDR2_2017+RECODR2_2017reHLT_skimSinglePh_Prompt+HARVEST2017.log

9.0 step3

runTheMatrix-results/9.0_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST/step3_Higgs200ChargedTaus+Higgs200ChargedTaus+DIGI+RECO+HARVEST.log

1306.0 step3

runTheMatrix-results/1306.0_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15/step3_SingleMuPt1_UP15+SingleMuPt1_UP15+DIGIUP15+RECOUP15+HARVESTUP15.log

25.0 step3

runTheMatrix-results/25.0_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT/step3_TTbar+TTbar+DIGI+RECOAlCaCalo+HARVEST+ALCATT.log

1000.0 step2

runTheMatrix-results/1000.0_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT/step2_RunMinBias2011A+RunMinBias2011A+TIER0+SKIMD+HARVESTDfst2+ALCASPLIT.log

1001.0 step2

runTheMatrix-results/1001.0_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5/step2_RunMinBias2011A+RunMinBias2011A+TIER0EXP+ALCAEXP+ALCAHARVD1+ALCAHARVD2+ALCAHARVD3+ALCAHARVD4+ALCAHARVD5.log

1330.0 step3

runTheMatrix-results/1330.0_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15/step3_ZMM_13+ZMM_13+DIGIUP15+RECOUP15+HARVESTUP15.log

10042.0 step3

runTheMatrix-results/10042.0_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

10024.0 step3

runTheMatrix-results/10024.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017_GenSimFull+DigiFull_2017+RecoFull_2017+ALCAFull_2017+HARVESTFull_2017.log

25202.0 step3

runTheMatrix-results/25202.0_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25/step3_TTbar_13+TTbar_13+DIGIUP15_PU25+RECOUP15_PU25+HARVESTUP15_PU25.log

10824.0 step3

runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+ALCAFull_2018+HARVESTFull_2018.log

11624.0 step3

runTheMatrix-results/11624.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2019_GenSimFull+DigiFull_2019+RecoFull_2019+ALCAFull_2019+HARVESTFull_2019.log

10224.0 step3

runTheMatrix-results/10224.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU/step3_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2017PU_GenSimFull+DigiFullPU_2017PU+RecoFullPU_2017PU+HARVESTFullPU_2017PU.log

20034.0 step3

runTheMatrix-results/20034.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D17_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D17+RecoFullGlobal_2023D17+HARVESTFullGlobal_2023D17.log

20434.0 step3

runTheMatrix-results/20434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D19_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D19+RecoFullGlobal_2023D19+HARVESTFullGlobal_2023D19.log

21234.0 step3

runTheMatrix-results/21234.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21/step3_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D21_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D21+RecoFullGlobal_2023D21+HARVESTFullGlobal_2023D21.log

AddOn:

I found errors in the following addon tests:

cmsDriver.py TTbar_8TeV_TuneCUETP8M1_cfi --conditions auto:run1_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot Realistic8TeVCollision : FAILED - time: date Fri Feb 2 19:15:28 2018-date Fri Feb 2 19:14:24 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_DATA.root --fileout file:RelVal_Raw_Fake2_DATA_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:16:23 2018-date Fri Feb 2 19:14:28 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_DATA.root --fileout file:RelVal_Raw_PRef_DATA_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:21:55 2018-date Fri Feb 2 19:14:30 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:25:09 2018-date Fri Feb 2 19:14:37 2018 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc_l1stage1 --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_25ns : FAILED - time: date Fri Feb 2 19:15:46 2018-date Fri Feb 2 19:14:39 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:PRef,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PRef --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PRef_MC.root --fileout file:RelVal_Raw_PRef_MC_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:23:52 2018-date Fri Feb 2 19:14:44 2018 s - exit: 18688
cmsDriver.py TTbar_13TeV_TuneCUETP8M1_cfi --conditions auto:run2_mc --fast -n 100 --eventcontent AODSIM,DQM --relval 100000,1000 -s GEN,SIM,RECOBEFMIX,DIGI:pdigi_valid,L1,DIGI2RAW,L1Reco,RECO,EI,VALIDATION --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --datatier GEN-SIM-DIGI-RECO,DQMIO --beamspot NominalCollision2015 --era Run2_2016 : FAILED - time: date Fri Feb 2 19:16:57 2018-date Fri Feb 2 19:15:15 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_DATA.root --fileout file:RelVal_Raw_PIon_DATA_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:19:41 2018-date Fri Feb 2 19:15:38 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run1_mc_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_MC.root --fileout file:RelVal_Raw_Fake_MC_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:24:06 2018-date Fri Feb 2 19:15:53 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake2,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake2 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2016 --processName=HLTRECO --filein file:RelVal_Raw_Fake2_MC.root --fileout file:RelVal_Raw_Fake2_MC_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:24:06 2018-date Fri Feb 2 19:17:02 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_MC.root --fileout file:RelVal_Raw_Fake1_MC_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:26:22 2018-date Fri Feb 2 19:19:44 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run1_data_Fake --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --processName=HLTRECO --filein file:RelVal_Raw_Fake_DATA.root --fileout file:RelVal_Raw_Fake_DATA_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:24:43 2018-date Fri Feb 2 19:22:36 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:27:53 2018-date Fri Feb 2 19:23:00 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:Fake1,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run2_data_Fake1 --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_25ns --processName=HLTRECO --filein file:RelVal_Raw_Fake1_DATA.root --fileout file:RelVal_Raw_Fake1_DATA_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:25:32 2018-date Fri Feb 2 19:24:01 2018 s - exit: 18688
cmsDriver.py RelVal -s HLT:PIon,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run2_mc_PIon --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run2_2018 --processName=HLTRECO --filein file:RelVal_Raw_PIon_MC.root --fileout file:RelVal_Raw_PIon_MC_HLT_RECO.root : FAILED - time: date Fri Feb 2 19:28:33 2018-date Fri Feb 2 19:24:06 2018 s - exit: 18688

cmsbuild · 2018-02-02T18:30:47Z

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

cmsbuild · 2018-02-02T20:36:01Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-02-02T20:38:26Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22092/3232

cmsbuild · 2018-02-02T20:38:46Z

Pull request #22092 was updated. @perrotta, @cmsbuild, @monttj, @slava77 can you please check and sign again.

perrotta · 2018-02-02T21:19:17Z

please test

cmsbuild · 2018-02-02T21:21:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/25882/console Started: 2018/02/02 22:22

cmsbuild · 2018-02-02T23:07:44Z

+1
Tested at: 531601c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22092/25882/summary.html

cmsbuild · 2018-02-02T23:07:46Z

Comparison job queued.

cmsbuild · 2018-02-03T00:33:28Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22092/25882/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22092/1325.7_TTbar_13_94XNanoAODINPUT+TTbar_13_94XNanoAODINPUT+NANOEDMMC2017

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 2 differences found in the comparisons
DQMHistoTests: Total files compared: 26
DQMHistoTests: Total histograms compared: 2465763
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2465593
DQMHistoTests: Total skipped: 169
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.02000000011 KiB( 22 files compared)
Checked 110 log files, 9 edm output root files, 26 DQM output files

perrotta · 2018-02-07T18:24:54Z

+1

The code changes do what said in the description
The capability to write out the subjets constituents is disabled by default (i.e. standard workflows are not affected) but can be enabled for the possible dedicated use cases

fabiocos · 2018-02-08T09:39:16Z

+1

fabiocos · 2018-02-08T09:39:46Z

merge

Adding capability to write out Ptrs in JetConstituentSelector (Backport of #22092)

Adding capability to write out Ptrs in JetConstituentSelector

3273fce

cmsbuild added this to the CMSSW_10_1_X milestone Feb 2, 2018

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Feb 2, 2018

rappoccio mentioned this pull request Feb 2, 2018

Adding capability to write out Ptrs in JetConstituentSelector (Backport of #22092) #22093

Merged

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 2, 2018

rappoccio mentioned this pull request Feb 2, 2018

Adding capability to write out Ptrs in JetConstituentSelector (Backport of #22092) #22094

Closed

perrotta reviewed Feb 2, 2018

View reviewed changes

cmsbuild added tests-started and removed tests-pending labels Feb 2, 2018

cmsbuild added comparison-notrun tests-rejected and removed comparison-pending tests-started labels Feb 2, 2018

Adjust to use default in fillDescriptions

531601c

cmsbuild removed code-checks-approved comparison-notrun labels Feb 2, 2018

cmsbuild added code-checks-pending comparison-pending tests-pending and removed tests-rejected labels Feb 2, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 2, 2018

cmsbuild added tests-started and removed tests-pending labels Feb 2, 2018

cmsbuild added tests-approved and removed tests-started labels Feb 2, 2018

cmsbuild added comparison-available and removed comparison-pending labels Feb 3, 2018

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Feb 7, 2018

cmsbuild added orp-approved and removed orp-pending labels Feb 8, 2018

cmsbuild merged commit bf01e69 into cms-sw:master Feb 8, 2018

cmsbuild added a commit that referenced this pull request Feb 15, 2018

Merge pull request #22093 from rappoccio/jetselector_ptrs

742139c

Adding capability to write out Ptrs in JetConstituentSelector (Backport of #22092)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding capability to write out Ptrs in JetConstituentSelector #22092

Adding capability to write out Ptrs in JetConstituentSelector #22092

rappoccio commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

perrotta Feb 2, 2018

rappoccio Feb 2, 2018

perrotta Feb 2, 2018

slava77 Feb 2, 2018

rappoccio Feb 2, 2018

davidlange6 commented Feb 2, 2018

cmsbuild commented Feb 2, 2018 •

edited

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

perrotta commented Feb 2, 2018

cmsbuild commented Feb 2, 2018 •

edited

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 3, 2018

perrotta commented Feb 7, 2018

fabiocos commented Feb 8, 2018

fabiocos commented Feb 8, 2018

Adding capability to write out Ptrs in JetConstituentSelector #22092

Adding capability to write out Ptrs in JetConstituentSelector #22092

Conversation

rappoccio commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

perrotta Feb 2, 2018

Choose a reason for hiding this comment

rappoccio Feb 2, 2018

Choose a reason for hiding this comment

perrotta Feb 2, 2018

Choose a reason for hiding this comment

slava77 Feb 2, 2018

Choose a reason for hiding this comment

rappoccio Feb 2, 2018

Choose a reason for hiding this comment

davidlange6 commented Feb 2, 2018

cmsbuild commented Feb 2, 2018 • edited

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

perrotta commented Feb 2, 2018

cmsbuild commented Feb 2, 2018 • edited

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 2, 2018

cmsbuild commented Feb 3, 2018

perrotta commented Feb 7, 2018

fabiocos commented Feb 8, 2018

fabiocos commented Feb 8, 2018

cmsbuild commented Feb 2, 2018 •

edited

cmsbuild commented Feb 2, 2018 •

edited