Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix: remove empty or undefined methods #22219

Merged
merged 1 commit into from Feb 15, 2018
Merged

Bug fix: remove empty or undefined methods #22219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions DQM/TrigXMonitor/interface/HLTScalers.h
View file
Open in desktop
Expand Up @@ -66,8 +66,8 @@
class HLTScalers : public DQMEDAnalyzer {
public:
HLTScalers(const edm::ParameterSet &ps);
~HLTScalers() override{};
void beginJob(void);
~HLTScalers() override = default;

void dqmBeginRun(const edm::Run &run, const edm::EventSetup &c) override;
void bookHistograms(DQMStore::IBooker &, edm::Run const &,
edm::EventSetup const &) override;
Expand Down
38 changes: 0 additions & 38 deletions DQMOffline/CalibCalo/src/DQMSourcePi0.cc
View file
Open in desktop
Expand Up @@ -321,25 +321,9 @@ void DQMSourcePi0::bookHistograms(DQMStore::IBooker & ibooker, edm::Run const &

hS4S92EtaEE_ = ibooker.book1D("S4S92EtaEE","S4S9 2nd most energetic Pi0 photon in EE",50,0.,1.);
hS4S92EtaEE_->setAxisTitle("S4S9 of the 2nd Eta Photon",1);




}

//--------------------------------------------------------
//void DQMSourcePi0::beginRun(const edm::Run& r, const EventSetup& context) {
//
//}

//--------------------------------------------------------
void DQMSourcePi0::beginLuminosityBlock(const LuminosityBlock& lumiSeg,
const EventSetup& context) {

}

//-------------------------------------------------------------

void DQMSourcePi0::analyze(const Event& iEvent,
const EventSetup& iSetup ){

Expand Down Expand Up @@ -1500,28 +1484,6 @@ void DQMSourcePi0::analyze(const Event& iEvent,

}




//--------------------------------------------------------
void DQMSourcePi0::endLuminosityBlock(const LuminosityBlock& lumiSeg,
const EventSetup& context) {
}
//--------------------------------------------------------
void DQMSourcePi0::endRun(const Run& r, const EventSetup& context){

}
//--------------------------------------------------------
void DQMSourcePi0::endJob(){

// if(dbe_) {
// if (saveToFile_) {
// dbe_->save(fileName_);
// }
// }
}


void DQMSourcePi0::convxtalid(Int_t &nphi,Int_t &neta)
{
// Barrel only
Expand Down
17 changes: 0 additions & 17 deletions DQMOffline/CalibCalo/src/DQMSourcePi0.h
View file
Open in desktop
Expand Up @@ -50,30 +50,14 @@ class DQMSourcePi0 : public DQMEDAnalyzer {

protected:

void beginJob();

// void beginRun(const edm::Run& r, const edm::EventSetup& c);
void bookHistograms(DQMStore::IBooker &, edm::Run const &, edm::EventSetup const &) override;
void analyze(const edm::Event& e, const edm::EventSetup& c) override ;

void beginLuminosityBlock(const edm::LuminosityBlock& lumiSeg,
const edm::EventSetup& context) override;

void endLuminosityBlock(const edm::LuminosityBlock& lumiSeg,
const edm::EventSetup& c) override;

void endRun(const edm::Run& r, const edm::EventSetup& c) override;

void endJob();

void convxtalid(int & , int &);
int diff_neta_s(int,int);
int diff_nphi_s(int,int);



private:


int eventCounter_;
PositionCalc posCalculator_ ;
Expand Down Expand Up @@ -344,4 +328,3 @@ class DQMSourcePi0 : public DQMEDAnalyzer {
};

#endif

5 changes: 1 addition & 4 deletions HLTriggerOffline/Egamma/interface/EmDQMReco.h
View file
Open in desktop
Expand Up @@ -90,11 +90,8 @@ class EmDQMReco : public DQMEDAnalyzer{
~EmDQMReco() override;

// Operations

void analyze(const edm::Event & event, const edm::EventSetup&) override;
void beginJob();
void endJob();
void dqmBeginRun( const edm::Run&, const edm::EventSetup& ) override;
void dqmBeginRun(const edm::Run&, const edm::EventSetup& ) override;
void bookHistograms(DQMStore::IBooker &, edm::Run const &, edm::EventSetup const &) override;

private:
Expand Down
7 changes: 0 additions & 7 deletions HLTriggerOffline/Egamma/src/EmDQMReco.cc
View file
Open in desktop
Expand Up @@ -889,11 +889,4 @@ template <class T> void HistoFillerReco<T>::fillHistos(edm::Handle<trigger::Trig
}


////////////////////////////////////////////////////////////////////////////////
// method called once each job just after ending the event loop //
////////////////////////////////////////////////////////////////////////////////
void EmDQMReco::endJob(){

}

DEFINE_FWK_MODULE(EmDQMReco);