Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed segmentation violation in PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor in case subjets are of type pat::Jet #22294

Merged
merged 2 commits into from Mar 2, 2018
Merged

Fixed segmentation violation in PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor in case subjets are of type pat::Jet #22294

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b26c4cc
Merge pull request #109 from cms-sw/CMSSW_9_4_X
arizzi Feb 8, 2018
bf5c417
fixed segmentation violation that occurred in subjet analyses in case…
veelken Feb 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 18 additions & 10 deletions PhysicsTools/SelectorUtils/interface/PFJetIDSelectionFunctor.h
View file
Open in desktop
Expand Up @@ -339,13 +339,24 @@ class PFJetIDSelectionFunctor : public Selector<pat::Jet> {
iend = patJet->end(), isub = ibegin;
isub != iend; ++isub ) {
reco::PFJet const * pfsub = dynamic_cast<reco::PFJet const *>( &*isub );
e_chf += pfsub->chargedHadronEnergy();
e_nhf += pfsub->neutralHadronEnergy();
e_cef += pfsub->chargedEmEnergy();
e_nef += pfsub->neutralEmEnergy();
nch += pfsub->chargedMultiplicity();
nconstituents += pfsub->numberOfDaughters();
nneutrals += pfsub->neutralMultiplicity();
pat::Jet const * patsub = dynamic_cast<pat::Jet const *>( &*isub );
if ( patsub ) {
e_chf += patsub->chargedHadronEnergy();
e_nhf += patsub->neutralHadronEnergy();
e_cef += patsub->chargedEmEnergy();
e_nef += patsub->neutralEmEnergy();
nch += patsub->chargedMultiplicity();
nconstituents += patsub->numberOfDaughters();
nneutrals += patsub->neutralMultiplicity();
} else if ( pfsub ) {
e_chf += pfsub->chargedHadronEnergy();
e_nhf += pfsub->neutralHadronEnergy();
e_cef += pfsub->chargedEmEnergy();
e_nef += pfsub->neutralEmEnergy();
nch += pfsub->chargedMultiplicity();
nconstituents += pfsub->numberOfDaughters();
nneutrals += pfsub->neutralMultiplicity();
} else assert(0);
}
double e = patJet->energy();
if ( e > 0.000001 ) {
Expand Down Expand Up @@ -407,8 +418,6 @@ class PFJetIDSelectionFunctor : public Selector<pat::Jet> {
}
} // end if basic jet



// Cuts for |eta| < 2.4 for FIRSTDATA, RUNIISTARTUP and WINTER16
if ( ignoreCut(indexCEF_) || ( cef < cut(indexCEF_, double()) || std::abs(jet.eta()) > 2.4 ) ) passCut( ret, indexCEF_);
if ( ignoreCut(indexCHF_) || ( chf > cut(indexCHF_, double()) || std::abs(jet.eta()) > 2.4 ) ) passCut( ret, indexCHF_);
Expand Down Expand Up @@ -443,7 +452,6 @@ class PFJetIDSelectionFunctor : public Selector<pat::Jet> {
if ( ignoreCut(indexNNeutrals_FW_) || ( nneutrals > cut(indexNNeutrals_FW_, int()) || std::abs(jet.eta()) <= 3.0 ) ) passCut( ret, indexNNeutrals_FW_);
}


//std::cout << "<PFJetIDSelectionFunctor::firstDataCuts>:" << std::endl;
//std::cout << " jet: Pt = " << jet.pt() << ", eta = " << jet.eta() << ", phi = " << jet.phi() << std::endl;
//ret.print(std::cout);
Expand Down