Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MET Significance Parameters with 80X Run2016 tune #22315

Merged
merged 1 commit into from Mar 2, 2018

Conversation

danbarto
Copy link
Contributor

Updating the parameters for MET Significance with the latest tune (as used in JME-17-001).

@cmsbuild cmsbuild changed the base branch from CMSSW_10_1_X to master February 23, 2018 10:04
@cmsbuild
Copy link
Contributor

@danbarto, CMSSW_10_1_X branch is closed for direct updates. cms-bot is going to move this PR to master branch.
In future, please use cmssw master branch to submit your changes.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @danbarto (Daniel) for master.

It involves the following packages:

RecoMET/METProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @ahinzmann, @mmarionncern, @jdamgov, @jdolen, @nhanvtran, @gkasieczka, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26257/console Started: 2018/02/23 11:29

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22315/26257/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 36 differences found in the comparisons
  • DQMHistoTests: Total files compared: 28
  • DQMHistoTests: Total histograms compared: 2498056
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2497879
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.03000000001 KiB( 23 files compared)
  • Checked 115 log files, 9 edm output root files, 28 DQM output files

@perrotta
Copy link
Contributor

@danbarto Can you provide a link to the studies/presentations that lead to these new parameters?

@danbarto
Copy link
Contributor Author

@perrotta Results are presented in JME-17-001. You can find a presentation from the JetMET workshop here: https://indico.cern.ch/event/639724/contributions/2593794/attachments/1459666/2254181/METSig_JMEWorkshopHelsinki.pdf

@perrotta
Copy link
Contributor

This PR updates the patMET significance in all workflows, see e.g. RunSinglePh2017B wf 136.788 from jenkins:
image

The (almost one year old) slides linked in #22315 (comment) do not show the improvement with respect to what was the previous tune, unless it was what in the slides is labelled as "pure MET". Therefore, let ask for a POG endorsement through the MET reco contacts: @gouskos @jdamgov

Moreover: this "Run2016 tune" is applied to all data, older and newer that 2016: is it correct?

@gouskos
Copy link
Contributor

gouskos commented Mar 2, 2018

Hi @perrotta, the comparison in these slides is vs "pure MET". The MET significance parameters in this PR are the latest we have in the MET group using the 2016 data. These are consistent with the ones used for the results presented in the run 2 paper [preapproved]. We will prepare a recipe so users can update the parameters on the fly., but the ones currently in miniAOD are quite old.

@perrotta
Copy link
Contributor

perrotta commented Mar 2, 2018

+1

  • MET significance parameters updated in miniAOD following the latest prescriptions of the MET group

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 2, 2018

+1

@cmsbuild cmsbuild merged commit ca572fe into cms-sw:master Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants