Migrate DQMEDAnalyze to producers #22319
Conversation
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22319/3528 |
|
A new Pull Request was created by @dmitrijus (Dmitrijus) for master. It involves the following packages: DQMServices/Components @smuzaffar, @Dr15Jones, @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
-1 Tested at: c528197 You can see the results of the tests here: I found follow errors while testing this PR Failed tests: Build
I found an error when building: from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-23-1100/src/DQM/EcalPreshowerMonitorClient/src/EcalPreshowerMonitorClient.cc:1:
/cvmfs/cms-ib.cern.ch/nweek-02512/slc6_amd64_gcc630/external/gcc/6.3.0-cms/include/c++/6.3.0/bits/unique_ptr.h: In instantiation of 'typename std::_MakeUniq<_Tp>::__single_object std::make_unique(_Args&& ...) [with _Tp = EcalPreshowerMonitorClient; _Args = {const edm::ParameterSet&}; typename std::_MakeUniq<_Tp>::__single_object = std::unique_ptr >]':
/cvmfs/cms-ib.cern.ch/nweek-02512/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_1_X_2018-02-23-1100/src/FWCore/Framework/src/MakeModuleHelper.h:41:40: required from 'static std::unique_ptr<_Tp> edm::MakeModuleHelper::makeModule(const edm::ParameterSet&) [with T = EcalPreshowerMonitorClient; Base = edm::one::EDProducerBase]'
/cvmfs/cms-ib.cern.ch/nweek-02512/slc6_amd64_gcc630/cms/cmssw-patch/CMSSW_10_1_X_2018-02-23-1100/src/FWCore/Framework/src/WorkerMaker.h:85:147: required from 'std::shared_ptr edm::WorkerMaker::makeModule(const edm::ParameterSet&) const [with T = EcalPreshowerMonitorClient]'
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-23-1100/src/DQM/EcalPreshowerMonitorClient/src/EcalPreshowerMonitorClient.cc:103:46: required from here
/cvmfs/cms-ib.cern.ch/nweek-02512/slc6_amd64_gcc630/external/gcc/6.3.0-cms/include/c++/6.3.0/bits/unique_ptr.h:791:30: error: invalid new-expression of abstract class type 'EcalPreshowerMonitorClient'
{ return unique_ptr<_Tp>(new _Tp(std::forward<_Args>(__args)...)); }
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-23-1100/src/DQM/EcalPreshowerMonitorClient/src/EcalPreshowerMonitorClient.cc:1:0:
/build/cmsbld/jenkins/workspace/ib-any-integration/CMSSW_10_1_X_2018-02-23-1100/src/DQM/EcalPreshowerMonitorClient/interface/EcalPreshowerMonitorClient.h:8:7: note: because the following virtual functions are pure within 'EcalPreshowerMonitorClient':
class EcalPreshowerMonitorClient : public DQMEDHarvester {
|
|
Comparison not run due to Build errors (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-rejected
and removed
comparison-pending
tests-started
labels
dmitrijus
force-pushed
the
dqm_is_less_broken_now_still_broken_though2
branch
from
c528197
to
5ff5346
Compare
cmsbuild
added
alca-pending
code-checks-pending
comparison-pending
and removed
code-checks-approved
comparison-notrun
tests-rejected
labels
|
Comparison job queued. |
|
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
|
+1 |
|
+1 |
cmsbuild
added
core-approved
fully-signed
and removed
core-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
@dmitrijus: congrats on much cleaner code--it is much clearer in terms of intent. I'm working on the concurrent booking of histograms in |
|
Ha ha ha |
|
(try not to break the DQM GUI, too) |
|
I would say that
@dmitrijus and @schneiml should be working on a test to outline the set of necessary changes, possible steps, and required features. |
|
@knoepfel yes, we should for sure have a talk at some point. We have a few plans on how to continue development -- and we can use any help we get. |
|
@fwyzard: agreed--let's not collide/duplicate efforts. @schneiml, @dmitrijus: I can meet by Zoom, Skype, or whatever. I can be available as early as 9 am (CST) tomorrow morning (2/28). Otherwise, it will likely need to wait until next week. |
|
+1 |
Also fixes MEtoEDMConverter.
Supersedes #22307