Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate DQMEDAnalyze to producers #22319

Merged
merged 13 commits into from Feb 28, 2018
Merged

Migrate DQMEDAnalyze to producers #22319

merged 13 commits into from Feb 28, 2018

Commits on Feb 23, 2018

  1. Switch to EDProducer. 

    Also re-introduce the .cc file, implementations in the header are to likely to confuse the build system.

(cherry picked from commit 6ea3613)
    @schneiml
    schneiml authored and Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    bb1a6df View commit details
    Browse the repository at this point in the history

  2. Another DQMEDAnalyzer config change 

    (cherry picked from commit 85a9c26)
    @schneiml
    schneiml authored and Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    fb65b0c View commit details
    Browse the repository at this point in the history

  3. Implement DQMToken @ Run support in DQMEDHarvester. 

    Removes unused meGetter better from DQMStore too.
    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    cba438c View commit details
    Browse the repository at this point in the history

  4. Convert EDMtoMEConverter to a producer, similar to DQMEDHarvester. 

    Also protect the DQMStore using usesResource, since all of this is
really dangerous.

(cherry picked from commit fdbe8d7)
    @schneiml
    schneiml authored and Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    9cbdb9f View commit details
    Browse the repository at this point in the history

  5. Some formal changes to MEtoEDMConverter. 

    Consume tokens, protect the DQMStore and watch all the transitions.

(cherry picked from commit ebe0a87)
    @schneiml
    schneiml authored and Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    19807c9 View commit details
    Browse the repository at this point in the history

  6. Copy run histograms as well as lumi histograms.

    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    3ace89a View commit details
    Browse the repository at this point in the history

  7. Modernize MEtoEDMConverter. 

    1. Remove useless statistics
2. Remove run reset (it does nothing multithread)
3. Switch to use iBooker/iGetter.
    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    022f5cc View commit details
    Browse the repository at this point in the history

  8. Modernize EDMtoMEConverter. Should not change behaviour in any way.

    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    ae452be View commit details
    Browse the repository at this point in the history

  9. Remove unused DQMStore::getAllTags.

    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    3b54d90 View commit details
    Browse the repository at this point in the history

  10. Apply code-checks.

    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    9a236d9 View commit details
    Browse the repository at this point in the history

  11. Use labels for DQMToken. 

    Also: remove useless private statistics from EDMtoMEConverter
Also: fix EDMtoMEConverter to actually produce DQMTokens
    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    dac5bb1 View commit details
    Browse the repository at this point in the history

  12. Migrate DQM/Phase2OuterTracker to use DQMEDAnalyzer alias.

    Dmitrijus Bugelskis committed Feb 23, 2018
    Copy the full SHA
    a897e11 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Move histogram production out of a activity registry callback and int… 

    …o *Produce.
    Dmitrijus Bugelskis committed Feb 27, 2018
    Copy the full SHA
    2b489f3 View commit details
    Browse the repository at this point in the history