Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Geant4 physics list to be similar to GeantV #22357

Merged
merged 2 commits into from Feb 27, 2018

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Feb 26, 2018

For comparison of the default Geant4 and new GeantV tracking an equivalent to GeanV EM physics constructor is proposed, where only gamma, e+, e- interactions are included.

This PR should not affect any production.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@civanch
Copy link
Contributor Author

civanch commented Feb 26, 2018

please test

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22357/3570

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22357/3570/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22357/3570/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

SimG4Core/PhysicsLists

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@civanch
Copy link
Contributor Author

civanch commented Feb 26, 2018

@bsunanda , this is EM physics fully equivalent to the 2018 GeantV physics (I have checked with GeantV developers). The PhysicsList name is "DummyPhysics". We can rename this if needed. This Physics List may be used for head-to head Geant4/GeantV comparison. In GeantV decay is not planned for this year but the DecayPhysics is left here , because allows instantiate all particles.

If the full EM physics is needed to be compared then FTFP_BERT_EMM or EML can be directly used for primary gamma, e+,e-, neutrino.

@civanch
Copy link
Contributor Author

civanch commented Feb 26, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26325/console Started: 2018/02/26 18:16

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22357/26325/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-22357/136.8311_RunJetHT2017F_reminiaod+RunJetHT2017F_reminiaod+REMINIAOD_data2017+HARVEST2017_REMINIAOD_data2017

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2500248
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2500071
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.17999999991 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@civanch
Copy link
Contributor Author

civanch commented Feb 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor Author

civanch commented Feb 27, 2018

@kpedro88 , this is one to one GeantV PhysList.

@kpedro88
Copy link
Contributor

thanks @civanch

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9200664 into cms-sw:master Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants