Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number of events, beginLumi's, and beginRun's to JobReport #22408

Merged
merged 1 commit into from Mar 2, 2018

Conversation

wddgit
Copy link
Contributor

@wddgit wddgit commented Mar 1, 2018

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

FWCore/Services

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@wddgit
Copy link
Contributor Author

wddgit commented Mar 1, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26416/console Started: 2018/03/01 23:22

@wddgit
Copy link
Contributor Author

wddgit commented Mar 1, 2018

One thing I noticed while testing this PR is that the Timing service (both before this PR and with this PR) does not work properly with SubProcesses. But even if we decide this problem is worth the development time to fix, I think that should be a separate pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22408/26416/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1013 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 4692
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2474153
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.12000000004 KiB( 21 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 2, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants