Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dijet prompt dqm (#19873) #22443

Merged
merged 7 commits into from Mar 7, 2018

Conversation

bobaekim
Copy link
Contributor

@bobaekim bobaekim commented Mar 3, 2018

Dear all,

I created new PR about #19873.

  • modified directory
  • decrease bins as similar as Jet Monitor

I tested those codes in CMSSW_10_0_3 with runTheMatrix 1325.
Your comments are welcomed and appreciated.
Thank you in advance.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2018

A new Pull Request was created by @bobaekim (Bobae Kim) for master.

It involves the following packages:

DQMOffline/Trigger

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@battibass, @mtosi, @jhgoh, @calderona, @HuguesBrun, @drkovalskyi, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

jfernan2 commented Mar 4, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26488/console Started: 2018/03/04 11:13

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22443/26488/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 4113.3 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@dmitrijus
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

The DQM histogram memory has been reduced by a factor of about 5 compared to the original proposal, according to the test. No new folder is added, the HLT/JME is filled with additional folders for the newly monitored paths. The histogram binning has been reduced.
Looking at the output of 136.788:

Total bytes: 201151.73 KiB | Total bytes: 201408.36 KiB
11963.23 KiB HLT/JME | 12377.90 KiB HLT/JME

The changes in the log files are gone.

@fabiocos
Copy link
Contributor

fabiocos commented Mar 7, 2018

+1

@cmsbuild cmsbuild merged commit 1106ee8 into cms-sw:master Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants