Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnlineDB/EcalCondDB: Clean up the following clang warnings: #22467

Merged
merged 1 commit into from Mar 20, 2018
Merged

OnlineDB/EcalCondDB: Clean up the following clang warnings: #22467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions OnlineDB/EcalCondDB/interface/LMFCorrCoefDatComponent.h
View file
Open in desktop
Expand Up @@ -40,6 +40,8 @@ class LMFCorrCoefDatComponent: public LMFDat {

LMFLmrSubIOV getLMFLmrSubIOV() const;
int getLMFLmrSubIOVID() const;
friend class LMFUnique;
using LMFUnique::getParameters;
std::vector<float> getParameters(const EcalLogicID &id);
std::vector<float> getParameterErrors(const EcalLogicID &id);
std::vector<float> getParameters(int id);
Expand Down
2 changes: 1 addition & 1 deletion OnlineDB/EcalCondDB/interface/LMFUnique.h
View file
Open in desktop
Expand Up @@ -86,11 +86,11 @@ class LMFUnique: public IUniqueDBObject {
virtual std::string setByIDSql(Statement *stmt,
int id) { return ""; }

virtual void getParameters(ResultSet *rset) {}
virtual void fetchParentIDs() {}
virtual LMFUnique * createObject() const;

protected:
virtual void getParameters(ResultSet *rset) {}
virtual int writeDB() noexcept(false);
virtual int writeForeignKeys() noexcept(false);
virtual void setClassName(std::string s) { m_className = s; }
Expand Down