Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnlineDB/EcalCondDB: Clean up the following clang warnings: #22467

Merged
merged 1 commit into from Mar 20, 2018
Merged

OnlineDB/EcalCondDB: Clean up the following clang warnings: #22467

merged 1 commit into from Mar 20, 2018

Conversation

gartung
Copy link
Member

@gartung gartung commented Mar 5, 2018

OnlineDB/EcalCondDB/interface/LMFCorrCoefDatComponent.h:43:23: warning: 'LMFCorrCoefDatComponent::getParameters' hides overloaded virtual function [-Woverloaded-virtual]

OnlineDB/EcalCondDB/interface/LMFCorrCoefDatComponent.h:45:23: warning: 'LMFCorrCoefDatComponent::getParameters' hides overloaded virtual function [-Woverloaded-virtual]

@gartung
Clean up the following clang warnings:
a710c4c 
OnlineDB/EcalCondDB/interface/LMFCorrCoefDatComponent.h:43:23: warning: 'LMFCorrCoefDatComponent::getParameters' hides overloaded virtual function [-Woverloaded-virtual]

OnlineDB/EcalCondDB/interface/LMFCorrCoefDatComponent.h:45:23: warning: 'LMFCorrCoefDatComponent::getParameters' hides overloaded virtual function [-Woverloaded-virtual]
@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Mar 5, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22467/3750

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

OnlineDB/EcalCondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@gartung
Copy link
Member Author

gartung commented Mar 5, 2018

@Dr15Jones

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 5, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26529/console Started: 2018/03/06 00:25

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

-1

Tested at: a710c4c

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d112bba
bfe12c4
79cf3e0
13169f3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26529/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26529/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26529/summary.html

I found follow errors while testing this PR

Failed tests: UnitTests

  • Unit Tests:

I found errors in the following unit tests:

---> test EcalIntercalib_update_test had ERRORS

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
d112bba
bfe12c4
79cf3e0
13169f3
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26529/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26529/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26529/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2479021
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2478844
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.05999999993 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@gartung gartung changed the title Clean up the following clang warnings: OnlineDB/EcalCondDB: Clean up the following clang warnings: Mar 6, 2018
@gartung
Copy link
Member Author

gartung commented Mar 6, 2018

Unable to reproduce the tests since I don't have the proper ~/.netrc.

@gartung gartung closed this Mar 6, 2018
@gartung
Copy link
Member Author

gartung commented Mar 9, 2018

Try again.

@gartung gartung reopened this Mar 9, 2018
@fabiocos
Copy link
Contributor

@gartung @Dr15Jones the failure is unrelated, and will disappear with the merge of #22505

@gartung
Copy link
Member Author

gartung commented Mar 13, 2018

@Dr15Jones please test
#22505 has been merged

@Dr15Jones
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 13, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26833/console Started: 2018/03/13 18:47

@cmsbuild
Copy link
Contributor

+1
Tested at: a710c4c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26833/summary.html

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22467/26833/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2477528
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2477351
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.13000000003 KiB( 22 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

@ggovi could you please check and sign in case?

@ggovi
Copy link
Contributor

ggovi commented Mar 20, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 9fbdcea into cms-sw:master Mar 20, 2018
@gartung gartung deleted the OnlineDB-EcalCondDB-clangwarning-cleanup branch March 26, 2018 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available db-approved fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_1_X
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gartung @cmsbuild @Dr15Jones @fabiocos @ggovi