New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing Easy Disabling/Enabling of E/gamma HLT track matching cuts #22525
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22525/3836 |
A new Pull Request was created by @Sam-Harper for master. It involves the following packages: RecoEgamma/EgammaHLTProducers @Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
At startup, the ECAL endcap is often missaligned w.r.t to the tracker which impacts the track matching cuts.
This has been the case for 2015, 2016 and 2017 and will be the case for 2018. In the past, we have manually changed the cuts (well via scripts) to fully relax the endcap cuts. Every year we have partially messed this up (some triggers slip through the cracks etc). So this year, we're controlling this with a central bool which can be easily toggled. When toggled, it zeros (or sets it to an other appropriate variable) all track matching cuts in the endcap. Right now it does it for all produced values including E/p which is probably not strickly necessary but this is on the safe side.
hltEgammaGsfTrackVars.useDefaultValuesForEndcap = cms.bool(True) and all E/gamma track cuts will automatically pass for endcap electrons.
@Martin-Grunewald