Fix compilation warnings in gcc7 IBs

[mrodozov]

PR #22560 introduced some warnings
https://cmssdt.cern.ch/SDT/cgi-bin/showBuildLogs.py/slc7_amd64_gcc700/www/tue/10.1-tue-11/CMSSW_10_1_X_2018-03-13-1100
adding virtual methods to a class with publicly accessible destructor this is fix.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22599/3932

[mrodozov]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26828/console Started: 2018/03/13 16:53

[cmsbuild]

A new Pull Request was created by @mrodozov (Mircho Rodozov) for master.

It involves the following packages:

FWCore/Framework

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

-1
The better solution would be to declare the destructor as virtual.

[smuzaffar]

abort test

[cmsbuild]

Jenkins tests are aborted.

[mrodozov]

updated

[cmsbuild]

+1
Tested at: f324bc3
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22599/26829/summary.html

[cmsbuild]

Comparison job queued.

[Dr15Jones]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22599/26829/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2477528
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2477351
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.00999999998 KiB( 22 files compared)
• Checked 118 log files, 9 edm output root files, 29 DQM output files

[cmsbuild]

From @smuzaffar: This is for slc6_amd64_gcc700. Things looks fine, there are no more warning.
-1

Tested at: f324bc3

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22599/26837/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

• RelVals:

When I ran the RelVals I found an error in the following worklfows:
150.0 step3

runTheMatrix-results/150.0_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018/step3_HydjetQ_B12_5020GeV_2018+HydjetQ_B12_5020GeV_2018+DIGIHI2018+RECOHI2018+HARVESTHI2018.log

[smuzaffar]

@Dr15Jones , slc6_amd64_gcc700 tests results are available https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22599/26837/summary.html

[Dr15Jones]

+1

[fabiocos]

@smuzaffar @Dr15Jones the crash is the AlcaBeamMonitor issue already seen on gcc7 for that workflow, it looks unrelated to this PR

[fabiocos]

+1