Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR 100X l1To2o fixes in EMTF and BMTF #22709

Closed
wants to merge 26 commits into from

Conversation

gekobs
Copy link
Contributor

@gekobs gekobs commented Mar 22, 2018

PR 100X
This PR contains:

kkotov and others added 26 commits October 13, 2017 11:29
…mmit even in case of errors (a trick of last resort not to be ran by default)
@thomreis
Copy link
Contributor

@gekobs the PRs linked in the description seem to be the wrong ones.
Is there also a PR to the master branch for this PR?

@rekovic
Copy link
Contributor

rekovic commented Mar 22, 2018

please test

@rekovic
Copy link
Contributor

rekovic commented Mar 22, 2018

@gekobs
Thanks.
(It turns out that this time) You can use the same branch to make a pull request to 10_1_X branch.
Also, make a change in the introduction 22699 --> 22669.

@rekovic
Copy link
Contributor

rekovic commented Mar 22, 2018

@gekobs
We should move the left-over relevant code from fakeEmtfParams_cfi.py into
L1TriggerConfig/L1TConfigProducers/python/L1TMuonEndCapForestOnline_cfi.py

But let's first have the tests complete.

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22709/27045/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2468519
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468349
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.700000000164 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@thomreis
Copy link
Contributor

backport of #22716

@rekovic
Copy link
Contributor

rekovic commented Mar 27, 2018

This is now tested on top of CMSSW_10_0_0, on the CondDB machines running L1T O2O (in directory /data/O2O/L1T/v12.1/) in the offline mode writing to sqlite file. The results are as expected:

  • BMTF and OMTF tags are updated to Stage2v1
  • Proper masking of DT channels done in BMTF depending if key is cosmics or p-p.

We plan to move /data/O2O/L1T/v12.1/ into production tomorrow.

@ggovi
Copy link
Contributor

ggovi commented Mar 27, 2018

+1

@rekovic
Copy link
Contributor

rekovic commented Mar 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@gekobs after the move to 10_1_X this PR can be closed

@fabiocos fabiocos closed this May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants