Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix - o2o bmtf #22669

Closed

Conversation

panoskatsoulis
Copy link
Contributor

This is a Quick Fix for the BMTF o2o issue,
the data/emulator mismatches.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2018

A new Pull Request was created by @panoskatsoulis for CMSSW_10_0_X.

It involves the following packages:

L1Trigger/L1TMuonBarrel

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @kreczko, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/26962/console Started: 2018/03/19 19:47

@thomreis
Copy link
Contributor

@panoskatsoulis please make also a PR to the master branch for this.

@panoskatsoulis
Copy link
Contributor Author

Just did the PR to the master.

@thomreis
Copy link
Contributor

backport of #22670

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22669/26962/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2468519
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2468349
  • DQMHistoTests: Total skipped: 169
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.640000000029 KiB( 22 files compared)
  • Checked 111 log files, 9 edm output root files, 27 DQM output files

@thomreis
Copy link
Contributor

thomreis commented Mar 20, 2018

Hi @rekovic
can you try with this PR if the BMTF record is produced as it should be?

@thomreis
Copy link
Contributor

Hi @panoskatsoulis @rekovic
is this PR still needed? I think the code is also included in PR #22709 .

@rekovic
Copy link
Contributor

rekovic commented Apr 19, 2018

@panoskatsoulis Please close this PR, as this is already in 10_1_X and 10_2_X.
No need to backport to 10_0_0. Thx.

@panoskatsoulis
Copy link
Contributor Author

Hello,
Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants