Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR 101X l1To2o fixes in EMTF and BMTF #22716

Merged
merged 26 commits into from Apr 3, 2018
Merged

PR 101X l1To2o fixes in EMTF and BMTF #22716

merged 26 commits into from Apr 3, 2018

Conversation

gekobs
Copy link
Contributor

@gekobs gekobs commented Mar 22, 2018 •
edited

PR 101X
This PR contains:

kkotov and others added 26 commits October 13, 2017 11:29
adding a small README.md to the L1T O2O core framework
9fab79b
Updating current tag versions
86d2b05
Cleaning legacy rudiments
cd577cb
Implementing a central teams request to be able to proceed with DB co…
1c7822d 
…mmit even in case of errors (a trick of last resort not to be ran by default)
Changing Endcap to EndCap (as it was really two words) to make some o…
8ffa497 
…ther developers happy
Adding a transactionSafe parameter to the configs
efcf399
Adding status printouts for the Function Manager
84cbfd3
A follow-up on cms-sw#19041 (comment)
9324eb4
Adding README.md
78613cb
Fixing the viewers
2161287
Decomissioning 2016 xml scheme
843e931
Instructing forests proxy to fetch payload from protoDB
d2bb6bd
Adding protoDBConnect
8b42762
Applying suggestions from the automated code-checks
ab8eebd
Merge branch 'synchO2O_171013' into from-CMSSW_9_4_X_2017-11-06-2300
4174507
Resolving something that git mistakenly identified as conflicts
a5540f3
@gekobs
Merged refs/pull/20939/head from repository cms-sw with cms-merge-topic
86de322
@panoskatsoulis
changes for BMTF ZS DQM Quality Test
0fe5075
@panoskatsoulis
quick o2o fix for the BMTF
6d6bdb8
@panoskatsoulis
quick o2o fix for the BMTF
e7a1f75
@panoskatsoulis
Revert "quick o2o fix for the BMTF"
2ee9c71 
This reverts commit 6d6bdb8.
@panoskatsoulis
Revert "quick o2o fix for the BMTF"
25a2fa1 
This reverts commit e7a1f75.
@panoskatsoulis
quick fix for the BMTF o2o
29fa9ec
@panoskatsoulis
removed DQM Quality Tests from this branch
abf291f
@gekobs
Merged refs/pull/22669/head from repository cms-sw with cms-merge-topic
987e229
@gekobs
fix muonEndCap forest
341877c
@cmsbuild cmsbuild added this to the CMSSW_10_1_X milestone Mar 22, 2018
@cmsbuild
Copy link
Contributor

+1
Tested at: 341877c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22716/27066/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
987e229
86de322
a5540f3
4174507
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22716/27066/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22716/27066/git-merge-result

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22716/27066/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2498300
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2498123
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.0100000001 KiB( 23 files compared)
  • Checked 118 log files, 9 edm output root files, 29 DQM output files

@thomreis thomreis mentioned this pull request Mar 26, 2018
Closed
@rekovic
Copy link
Contributor

rekovic commented Mar 27, 2018

This is now tested on the CondDB machines running L1T O2O (in directory /data/O2O/L1T/v12.1/) in the offline mode writing to sqlite file. The results are as expected:

  • BMTF and OMTF tags are updated to Stage2v1
  • Proper masking of DT channels done in BMTF depending if key is cosmics or p-p.

We plan to move /data/O2O/L1T/v12.1/ into production tomorrow.

@rekovic
Copy link
Contributor

rekovic commented Mar 27, 2018

+1

@ggovi
Copy link
Contributor

ggovi commented Mar 27, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@thomreis
Copy link
Contributor

This PR contains also commits from #20939, not #20929 as mentioned in the description.

@smuzaffar smuzaffar modified the milestones: CMSSW_10_1_X, CMSSW_10_2_X Mar 29, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Apr 3, 2018

+1

@cmsbuild cmsbuild merged commit dfea4be into cms-sw:master Apr 3, 2018
This was referenced Apr 6, 2018
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available db-approved fully-signed l1-approved orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_2_X
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@gekobs @cmsbuild @rekovic @fabiocos @ggovi @thomreis @smuzaffar @panoskatsoulis