HCALDQM: Update DigiTask for 2018 HE (10_1_X)

[DryRun]

Updates HCALDQM DigiTask for 2018 HE. A number of plots were not filled for HEP17 last year because it would have mixed QIE8 and QIE11 digis; QIE11-specific plots were created in QIE11Task. Now that HE==QIE11, I integrated the plots of interest from QIE11Task to DigiTask.

I also included one small bug fix for LaserTask: with the 2018 HE, the range for the laser signal has to be increased.

Note that I based this PR on top of #22595, which fixed the new digi size for 2018 in DigiTask, so that PR should be merged first.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22724/4092

[cmsbuild]

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks
DQM/Integration

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@makortel, @deguio, @threus, @batinkov, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22724/4093

[cmsbuild]

The code-checks are being triggered in jenkins.

[DryRun]

Hi @fabiocos - yes, that is correct, QIE11Task was indeed not run for offline DQM, so several plots are new additions. I think most of the memory comes from the _cLETDCTimevsADC_SubdetPM set of plots, which added 6 256x250 histograms (HB+, HB-, HE+, HE-, HO+, HO-; HF+ and HF- were already present). This fine granularity isn't necessary, so I reduced the 250 bins to 100 bins (i.e. keep the ADC granularity, but reduce the time granularity from 1 ns to 2.5 ns).

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22724/4247

[cmsbuild]

Pull request #22724 was updated. @vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please check and sign again.

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27324/console Started: 2018/04/05 21:46

[cmsbuild]

+1
Tested at: e07aec5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22724/27324/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22724/27324/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2498516
• DQMHistoTests: Total failures: 277
• DQMHistoTests: Total nulls: 47
• DQMHistoTests: Total successes: 2498016
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 18920.89 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1