DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual #22763

gartung · 2018-03-27T19:58:08Z

In file included from /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/V0Candidate/src/V0Candidate.cc:1:
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/V0Candidate/interface/V0Candidate.h:23:10: warning: 'reco::V0Candidate::setVertex' hides overloaded virtual function [-Woverloaded-virtual]
void setVertex( const Vertex & vtxIn );
^
/build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/Candidate/interface/LeafCandidate.h:158:10: note: hidden overloaded virtual function 'reco::LeafCandidate::setVertex' declared here: type mismatch at 1st parameter ('const reco::LeafCandidate::Point &' (aka 'const PositionVector3D<ROOT::Math::Cartesian3D > &') vs 'const reco::Vertex &')
void setVertex( const Point & vertex ) override { m_state.setVertex(vertex); }
^
1 warning generated.

In file included from /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/V0Candidate/src/V0Candidate.cc:1: /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/V0Candidate/interface/V0Candidate.h:23:10: warning: 'reco::V0Candidate::setVertex' hides overloaded virtual function [-Woverloaded-virtual] void setVertex( const Vertex & vtxIn ); ^ /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/Candidate/interface/LeafCandidate.h:158:10: note: hidden overloaded virtual function 'reco::LeafCandidate::setVertex' declared here: type mismatch at 1st parameter ('const reco::LeafCandidate::Point &' (aka 'const PositionVector3D<ROOT::Math::Cartesian3D<double> > &') vs 'const reco::Vertex &') void setVertex( const Point & vertex ) override { m_state.setVertex(vertex); } ^ 1 warning generated.

cmsbuild · 2018-03-27T19:58:25Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-03-27T19:59:56Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22763/4135

cmsbuild · 2018-03-27T20:00:15Z

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

DataFormats/V0Candidate

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@rovere this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

perrotta · 2018-03-27T20:36:07Z

@cmsbuild please test

cmsbuild · 2018-03-27T20:36:24Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27148/console Started: 2018/03/27 22:38

cmsbuild · 2018-03-27T22:10:44Z

+1
Tested at: ad57dde
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22763/27148/summary.html

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
e286936
6a6722e
d36e167
52f1966
fd1284b
b99808e
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22763/27148/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22763/27148/git-merge-result

cmsbuild · 2018-03-27T22:10:47Z

Comparison job queued.

cmsbuild · 2018-03-27T22:54:25Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22763/27148/summary.html

Comparison Summary:

No significant changes to the logs found
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 12 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2501580
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2501397
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 635.7 KiB( 16 files compared)
Checked 118 log files, 9 edm output root files, 29 DQM output files

perrotta · 2018-03-28T07:44:45Z

@cmsbuild please test
(I expect that differences in tests disappear once the extra commits are not tested together)

cmsbuild · 2018-03-28T07:47:01Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27155/console Started: 2018/03/28 09:48

cmsbuild · 2018-03-28T17:27:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-03-28T17:29:45Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22763/4155

cmsbuild · 2018-03-28T17:30:02Z

Pull request #22763 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

slava77 · 2018-03-28T19:14:59Z

@cmsbuild please test

@gartung
thank you for the update

cmsbuild · 2018-03-28T19:15:18Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27175/console Started: 2018/03/28 21:16

cmsbuild · 2018-03-28T20:36:44Z

+1
Tested at: 9f060f4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22763/27175/summary.html

cmsbuild · 2018-03-28T20:36:47Z

Comparison job queued.

cmsbuild · 2018-03-28T21:15:21Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22763/27175/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 29
DQMHistoTests: Total histograms compared: 2501822
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2501645
DQMHistoTests: Total skipped: 176
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 1.12000000003 KiB( 22 files compared)
Checked 119 log files, 9 edm output root files, 29 DQM output files

slava77 · 2018-03-28T21:53:41Z

+1

for #22763 9f060f4

removed ambiguity in manes between void V0Candidate::setVertex( const Vertex & vtxIn and its base with a different argument. This is a technical change.
jenkins tests pass; the full compilation confirms that the method is not used in CMSSW

cmsbuild · 2018-03-28T21:53:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-03-30T15:38:00Z

+1

cmsbuild added this to the CMSSW_10_1_X milestone Mar 27, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Mar 27, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 27, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 27, 2018

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2018

cmsbuild added comparison-available and removed comparison-pending labels Mar 27, 2018

cmsbuild added comparison-pending tests-pending and removed comparison-available tests-approved labels Mar 28, 2018

cmsbuild added the tests-pending label Mar 28, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 28, 2018

cmsbuild added tests-started and removed tests-pending labels Mar 28, 2018

cmsbuild added tests-approved and removed tests-started labels Mar 28, 2018

cmsbuild added comparison-available and removed comparison-pending labels Mar 28, 2018

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Mar 28, 2018

smuzaffar modified the milestones: CMSSW_10_1_X, CMSSW_10_2_X Mar 29, 2018

cmsbuild added orp-approved and removed orp-pending labels Mar 30, 2018

cmsbuild merged commit 7564122 into cms-sw:master Mar 30, 2018

gartung deleted the DataFormats-V0Candidate-fix-clang-warn branch April 6, 2018 21:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual #22763

DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual #22763

gartung commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

perrotta commented Mar 27, 2018

cmsbuild commented Mar 27, 2018 •

edited

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

perrotta commented Mar 28, 2018

cmsbuild commented Mar 28, 2018 •

edited

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

slava77 commented Mar 28, 2018

cmsbuild commented Mar 28, 2018 •

edited

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

slava77 commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

fabiocos commented Mar 30, 2018

DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual #22763

DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual #22763

Conversation

gartung commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

perrotta commented Mar 27, 2018

cmsbuild commented Mar 27, 2018 • edited

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

cmsbuild commented Mar 27, 2018

perrotta commented Mar 28, 2018

cmsbuild commented Mar 28, 2018 • edited

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

slava77 commented Mar 28, 2018

cmsbuild commented Mar 28, 2018 • edited

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

slava77 commented Mar 28, 2018

cmsbuild commented Mar 28, 2018

fabiocos commented Mar 30, 2018

cmsbuild commented Mar 27, 2018 •

edited

cmsbuild commented Mar 28, 2018 •

edited

cmsbuild commented Mar 28, 2018 •

edited