Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual #22763

Merged
merged 2 commits into from
Mar 30, 2018
Merged

DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual #22763

merged 2 commits into from
Mar 30, 2018

Commits on Mar 27, 2018

  1. DataFormats/V0Candidate: fix for clang warning -Woverloaded-virtual

    In file included from /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/V0Candidate/src/V0Candidate.cc:1:
      /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/V0Candidate/interface/V0Candidate.h:23:10: warning: 'reco::V0Candidate::setVertex' hides overloaded virtual function [-Woverloaded-virtual]
         void setVertex( const Vertex & vtxIn );
             ^
    /build/cmsbld/jenkins/workspace/build-any-ib/w/tmp/BUILDROOT/c6796210c53b02f1870cdf07f5d562c4/opt/cmssw/slc6_amd64_gcc630/cms/cmssw/CMSSW_10_1_CLANG_X_2018-03-26-2300/src/DataFormats/Candidate/interface/LeafCandidate.h:158:10: note: hidden overloaded virtual function 'reco::LeafCandidate::setVertex' declared here: type mismatch at 1st parameter ('const reco::LeafCandidate::Point &' (aka 'const PositionVector3D<ROOT::Math::Cartesian3D<double> > &') vs 'const reco::Vertex &')
        void setVertex( const Point & vertex ) override   { m_state.setVertex(vertex); }
             ^
    1 warning generated.
    gartung committed Mar 27, 2018
    Configuration menu
    Copy the full SHA
    ad57dde View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2018

  1. Rename setVertex to setRecoVertex to match getRecoVertex. Added advan…

    …tage: it no longer shadows setVertex from base class.
    gartung committed Mar 28, 2018
    Configuration menu
    Copy the full SHA
    9f060f4 View commit details
    Browse the repository at this point in the history