New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix preexisting tracker alignment validation #22799
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22799/4176 |
A new Pull Request was created by @hroskes (Heshy Roskes) for master. It involves the following packages: Alignment/OfflineValidation @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22799/4192 |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
hello @hroskes , could you please make the title a bit more explicit , by mentioning that this is for tracker alignment for example ? [hard otherwise from the release notes to get that it's not for the validation of ecal, pflow, tau or whatever CMS validation components, and the release notes are, among many other purposes, a key ingredients for the validators ] Thank you. |
hi @boudoul, I fixed the title |
Thanks @hroskes ! |
+1 |
Fixing a stupid mistake. The default behavior is setting this parameter to "true" which doesn't work with int. I missed this one place in 297cb18.