Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preexisting tracker alignment validation #22799

Merged
merged 2 commits into from Apr 4, 2018

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Mar 29, 2018

Fixing a stupid mistake. The default behavior is setting this parameter to "true" which doesn't work with int. I missed this one place in 297cb18.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @hroskes (Heshy Roskes) for master.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #22799 was updated. @ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please check and sign again.

@arunhep
Copy link
Contributor

arunhep commented Mar 31, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27212/console Started: 2018/03/31 04:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22799/27212/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2501849
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2501672
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.94999999999 KiB( 23 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Apr 3, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@boudoul
Copy link
Contributor

boudoul commented Apr 3, 2018

hello @hroskes , could you please make the title a bit more explicit , by mentioning that this is for tracker alignment for example ? [hard otherwise from the release notes to get that it's not for the validation of ecal, pflow, tau or whatever CMS validation components, and the release notes are, among many other purposes, a key ingredients for the validators ] Thank you.

@hroskes hroskes changed the title fix preexisting validation fix preexisting tracker alignment validation Apr 3, 2018
@hroskes
Copy link
Contributor Author

hroskes commented Apr 3, 2018

hi @boudoul, I fixed the title

@boudoul
Copy link
Contributor

boudoul commented Apr 3, 2018

Thanks @hroskes !

@fabiocos
Copy link
Contributor

fabiocos commented Apr 4, 2018

+1

@cmsbuild cmsbuild merged commit 285a1d8 into cms-sw:master Apr 4, 2018
@hroskes hroskes deleted the fix-preexisting-validation branch April 16, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants