Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix preexisting tracker alignment validation #22800

Merged
merged 2 commits into from Apr 5, 2018

Conversation

hroskes
Copy link
Contributor

@hroskes hroskes commented Mar 29, 2018

backport of #22799

Fixing a stupid mistake. The default behavior is setting this parameter to "true" which doesn't work with int. I missed this one place in 297cb18.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 29, 2018

A new Pull Request was created by @hroskes (Heshy Roskes) for CMSSW_10_1_X.

It involves the following packages:

Alignment/OfflineValidation

@ghellwig, @arunhep, @cerminar, @cmsbuild, @franzoni, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @ghellwig, @mmusich, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@arunhep
Copy link
Contributor

arunhep commented Mar 31, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 31, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27213/console Started: 2018/03/31 04:42

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22800/27213/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2501822
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2501645
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.20000000005 KiB( 23 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Apr 3, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@hroskes hroskes changed the title fix preexisting validation fix preexisting tracker alignment validation Apr 3, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

+1

@cmsbuild cmsbuild merged commit 715fa0c into cms-sw:CMSSW_10_1_X Apr 5, 2018
@fabiocos fabiocos mentioned this pull request Apr 5, 2018
16 tasks
@hroskes hroskes deleted the fix-preexisting-validation branch April 16, 2018 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants