Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features needed for CMSSW_10_1_1 #22865

Closed
11 of 16 tasks
fabiocos opened this issue Apr 5, 2018 · 18 comments
Closed
11 of 16 tasks

Features needed for CMSSW_10_1_1 #22865

fabiocos opened this issue Apr 5, 2018 · 18 comments

Comments

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

The validation of CMSSW_10_1_0 is ongoing, we already know that we need to back-port some fixes and some last minute planned additions. The target is a CMSSW_10_1_1 containing features already deployed and to be validated in 10_2_0_pre1 (the build and validation of these two releases will have to move unfortunately in parallel).

(Updated on April 7 23:00)

Here is the list of the PRs already backported from 10_2_X as fixes:

#22822 from cms-tsg-storm: Fix l1 emulation in HLT scripts (101X)
#22823 from folguera: BugFix for L3MuonCandidateProducerFromMuons
#22819 from bsunanda: Run2-alca126 Add eta dependent threshold for ECAL
#22818 from mmusich: [10.1.X] fix segmentation fault in SiStripBadComponentInfo (backport)
#22792 from thomreis: Fix L1T muon copy comparison DQM harvesting path - 101x
#22791 from mmusich: [10.1.X] remove useless triplication of AAG data in calibTree
#22800 from hroskes: fix preexisting tracker alignment validation

This issue is meant to collect the other features that are really necessary for the operations at the beginning of data taking and for the completion of the PF calibration.

The list that I am aware of at present is:

Please add further motivated requests to this issue

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 5, 2018

A new Issue was created by @fabiocos Fabio Cossutti.

@davidlange6, @Dr15Jones, @smuzaffar, @fabiocos can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor

@fabiocos #22860 is needed to avoid the exception seen in AlcaBeamMonitor

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 5, 2018

@popovvp @fabferro I understand that, besides #22858, for CTPPS we need also the backport of #22678 could you please provide it ?

@fabferro
Copy link
Contributor

fabferro commented Apr 5, 2018

@fabiocos: yes we are going to open the backport of #22678 asap.

@lpernie
Copy link
Contributor

lpernie commented Apr 5, 2018

From Alca side we need:
#22834 (2018 GT change)
#22857 (sunanda alcareco fix)
#22854 (SiPixelQuality memory cost mitigation)
#22858 and #22866 (ctpps fixes)
#22831 , #22832 (fix in O2O)
@ggovi , @arunhep you can cross-check this list.

@fabferro
Copy link
Contributor

fabferro commented Apr 5, 2018

I've opened PR #22866 as a backport of PR #22678
@fabiocos @popovvp

@arunhep
Copy link
Contributor

arunhep commented Apr 5, 2018

adding to what @lpernie already mentioned :
#22870 (for Lumi PCC PCL workflow)
and we are expecting a PR tomorrow which is needed to deploy new LHCInfo O2O
we will mention it here once it will be opened.

@Martin-Grunewald
Copy link
Contributor

Martin-Grunewald commented Apr 6, 2018

For TSG we request:

10_2_X/10_2_0_pre1
#22833 (2018 Conditions with new L1T menu)
#22863 (bug fix in EgammaHLTGsfTrackVarProducer)

10_1_X/10_1_1
#22834 (2018 Conditions with new L1T menu - backport)
#22864 (bug fix in EgammaHLTGsfTrackVarProducer - backport)
#22824 (backport for HLT menu migration to 10_1 template - already in 10_2_X)

@deguio
Copy link
Contributor

deguio commented Apr 6, 2018

hi @fabiocos
it would be good to have the following PRs merged as well.
#22848 (10_2_X)
#22849 (10_1_X)

which are a minor fix for the TP emulator for HCAL
thanks.

@christopheralanwest @abdoulline @mariadalfonso

@thomreis
Copy link
Contributor

thomreis commented Apr 6, 2018

Hi @fabiocos
For L1T we would like to have these in 10_1_1 if possible.
#22794
#22793
#22795
#22880
@rekovic please take a look as well.

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 6, 2018

@deguio as we discussed at the operation meeting, #22849 can come at a later stage without rushing (not yet approved in master), so I will remove it from the list

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 7, 2018

@arunhep @lpernie Huston we have a problem...

After the integration in 10_2_X of the GT PR #22833 (whose backport #22834 should be one of the key residual ingredients for 10_1_1) we are getting several failures in tonight's IB, see for instance

https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc630/CMSSW_10_2_X_2018-04-06-2300/pyRelValMatrixLogs/run/136.77_RunDoubleEG2016H+RunDoubleEG2016H+HLTDR2_2016+RECODR2_2016reHLT_skimDoubleEG_Prompt+HARVESTDR2/step3_RunDoubleEG2016H+RunDoubleEG2016H+HLTDR2_2016+RECODR2_2016reHLT_skimDoubleEG_Prompt+HARVESTDR2.log

They are reproducible, do not appear if only the GT PR is not used (In any case the other additions tonight look unrelated to this), and have the pattern

%MSG
----- Begin Fatal Exception 07-Apr-2018 07:13:54 CEST-----------------------
An exception of category 'Configuration' occurred while
[0] Processing Event run: 283877 lumi: 3 event: 3979066 stream: 2
[1] Running path 'pathALCARECOEcalESAlign'
[2] Calling method for module HLTHighLevel/'ALCARECOEcalESAlignHLT'
Exception Message:
HLTHighLevel [instance: ALCARECOEcalESAlignHLT - path: pathALCARECOEcalESAlign]: No triggerList with key EcalESAlign in AlCaRecoTriggerBitsRcd
----- End Fatal Exception -------------------------------------------------

A test on some of the failing workflows is running in #22834 to cross check that this appears also in the 10_1_X branch.

Any clue of what is wrong/missing? Needless to say that this is a show-stopper for 10_2_0_pre1 and 10_1_1 if not solved.

@arunhep
Copy link
Contributor

arunhep commented Apr 7, 2018

@fabiocos i know the problem. i will open a PR soon.

@arunhep
Copy link
Contributor

arunhep commented Apr 7, 2018

These PRs :
master : #22892
10.1.X : #22893
should fix the issue.

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 7, 2018

@arunhep #22897 combines #22834 and the fix #22893 (which should be rebased)

@fabozzi
Copy link
Contributor

fabozzi commented Apr 7, 2018

Hi, for PdmV it would be nice to have the updated GENSIM for relvals:
#22894 (master)
#22895 (101X)

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 8, 2018

@fabozzi the new datasets look all at CERN, so I expect we should have no failures due to missing inputs

@fabiocos
Copy link
Contributor Author

fabiocos commented Apr 8, 2018

At this point I will freeze the present situation, more additions may come in a following patch/release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants