[10.1.X] fix segmentation fault in SiStripBadComponentInfo (backport)

[mmusich]

backport of #22719

Title says is it all: attempt to fix issue #22695.
Access to the TrackerTopology from DB is moved from dqmEndJob to endRun where framework should guarantee edm::EventSetup components are still accessible. Bin contents of the output monitor element are cached in a std::map.
This reverts also #22690.
Tested locally with wf. runTheMatrix.py -l 4.6 -t 4

type bug-fix

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for CMSSW_10_1_X.

It involves the following packages:

DQM/SiStripMonitorClient

@vazzolini, @kmaeshima, @dmitrijus, @cmsbuild, @jfernan2, @vanbesien can you please review it and eventually sign? Thanks.
@idebruyn, @threus, @fioriNTU, @hdelanno, @venturia this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

• Backported from fix segmentation fault in SiStripBadComponentInfo #22719

[jfernan2]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27228/console Started: 2018/04/02 00:00

[jfernan2]

please test

[cmsbuild]

+1
Tested at: 0ee68b8
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22818/27228/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22818/27228/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2501822
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2501645
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.899999999994 KiB( 23 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[dmitrijus]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1