Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the popcon procedure #22832

Conversation

ggovi
Copy link
Contributor

@ggovi ggovi commented Apr 3, 2018

Fix for file handling: delete after copy, save for upload errors

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

A new Pull Request was created by @ggovi for CMSSW_10_1_X.

It involves the following packages:

CondCore/Utilities

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ggovi
Copy link
Contributor Author

ggovi commented Apr 3, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27254/console Started: 2018/04/03 17:45

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22832/27254/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 29
  • DQMHistoTests: Total histograms compared: 2501822
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2501645
  • DQMHistoTests: Total skipped: 176
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.930000000051 KiB( 22 files compared)
  • Checked 119 log files, 9 edm output root files, 29 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Apr 5, 2018

@ggovi if this is needed in operations please sign it asap...

@fabiocos fabiocos mentioned this pull request Apr 5, 2018
16 tasks
@ggovi
Copy link
Contributor Author

ggovi commented Apr 10, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 391a729 into cms-sw:CMSSW_10_1_X Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants