Fixing bug in default values for EgammaHLTGsfTrackVarProducer : 10_2_X

[Sam-Harper]

This PR fixes a bug in the default values of EgammaHLTGsfTrackVarProducer which incorrectly sets 1/E-1/p default values to 1 rather than 0. This is now fixed.

This PR is needed rather urgently to relax the electron cuts for startup for the HLT. Can we slip it into CMSSW_10_1_1?
@Martin-Grunewald

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-22863/4252

[cmsbuild]

A new Pull Request was created by @Sam-Harper for master.

It involves the following packages:

RecoEgamma/EgammaHLTProducers

@Martin-Grunewald, @silviodonato, @cmsbuild, @fwyzard can you please review it and eventually sign? Thanks.
@battibass, @jainshilpi, @lgray, @calderona, @HuguesBrun, @drkovalskyi, @varuns23, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[silviodonato]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27321/console Started: 2018/04/05 20:31

[cmsbuild]

+1
Tested at: aaaff8f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22863/27321/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22863/27321/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2498516
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2498339
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.07999999991 KiB( 22 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[Martin-Grunewald]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/27337/console Started: 2018/04/06 09:09

[Martin-Grunewald]

type bugfix

[Martin-Grunewald]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

+1
Tested at: aaaff8f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22863/27337/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-22863/27337/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 29
• DQMHistoTests: Total histograms compared: 2504246
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2504069
• DQMHistoTests: Total skipped: 176
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 1.11000000022 KiB( 22 files compared)
• Checked 119 log files, 9 edm output root files, 29 DQM output files

[fabiocos]

+1